Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2679963003: Added a getter for properties variable in css_properties.py. (Closed)

Created:
3 years, 10 months ago by aazzam
Modified:
3 years, 10 months ago
Reviewers:
sashab, ktyliu, shend
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added a getter for properties variable in css_properties.py. Added a getter to return private properties variable from css_properties.py. This is prework for using this variable from CSSPropertyAPIWriter in make_css_property_apis.py, and potentially other classes which need access to the CSS properties but do not inherit from CSSProperties. Review-Url: https://codereview.chromium.org/2679963003 Cr-Commit-Position: refs/heads/master@{#449183} Committed: https://chromium.googlesource.com/chromium/src/+/e530306fa63d398f6eb9e9a7bb33ac310fd7925b

Patch Set 1 #

Patch Set 2 : Replaced with making a getter #

Total comments: 1

Messages

Total messages: 15 (6 generated)
aazzam
ptal sasha and kevin :) also ptal at CL desc. darren! :)
3 years, 10 months ago (2017-02-08 02:20:26 UTC) #3
sashab
Are there any other files that do this? I think maybe we should add a ...
3 years, 10 months ago (2017-02-08 02:22:03 UTC) #4
aazzam
On 2017/02/08 at 02:22:03, sashab wrote: > Are there any other files that do this? ...
3 years, 10 months ago (2017-02-08 02:32:13 UTC) #6
sashab
Haha! Nice one. LGTM
3 years, 10 months ago (2017-02-08 02:33:34 UTC) #7
aazzam
ptal kevin! :)
3 years, 10 months ago (2017-02-08 02:48:30 UTC) #8
shend
On 2017/02/08 at 02:20:26, aazzam wrote: > ptal sasha and kevin :) also ptal at ...
3 years, 10 months ago (2017-02-08 03:26:30 UTC) #9
ktyliu
I don't have objections to this, but note you can just have this change in ...
3 years, 10 months ago (2017-02-08 04:29:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679963003/20001
3 years, 10 months ago (2017-02-09 00:09:37 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 01:47:26 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e530306fa63d398f6eb9e9a7bb33...

Powered by Google App Engine
This is Rietveld 408576698