Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2679933003: Avoid setting CustomEvent.detail property in initCustomEvent while dispatch an event. (Closed)

Created:
3 years, 10 months ago by lpy
Modified:
3 years, 10 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid setting CustomEvent.detail property in initCustomEvent while dispatch an event. BUG=684843 Review-Url: https://codereview.chromium.org/2679933003 Cr-Commit-Position: refs/heads/master@{#448794} Committed: https://chromium.googlesource.com/chromium/src/+/aa57f762dfa15e283219c3ff3e9c8b9d611cae7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
D third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-init-while-dispatching-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
lpy
PTAL.
3 years, 10 months ago (2017-02-07 22:01:15 UTC) #9
tkent
lgtm
3 years, 10 months ago (2017-02-07 23:31:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679933003/20001
3 years, 10 months ago (2017-02-07 23:37:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/aa57f762dfa15e283219c3ff3e9c8b9d611cae7c
3 years, 10 months ago (2017-02-07 23:44:41 UTC) #15
haraken
3 years, 10 months ago (2017-02-08 00:01:54 UTC) #16
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698