third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp - Issue 2679933003: Avoid setting CustomEvent.detail property in initCustomEvent while dispatch an event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

Issue 2679933003: Avoid setting CustomEvent.detail property in initCustomEvent while dispatch an event. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

index 6f10be994a901f249eec7be1640217eeef29b699..17470c13528163884e355ec273b9efef66e40d1a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

@@ -107,6 +107,8 @@ void V8CustomEvent::initCustomEventMethodEpilogueCustom(

const v8::FunctionCallbackInfo<v8::Value>& info,

CustomEvent* impl) {

ASSERT(info.Length() >= 3);

+ if (impl->isBeingDispatched())

+ return;

v8::Local<v8::Value> detail = info[3];

if (!detail.IsEmpty())

storeDetail(ScriptState::current(info.GetIsolate()), impl, info.Holder(),

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-init-while-dispatching-expected.txt ('k') | no next file » | no next file with comments »