Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2679513002: Track the original opener of a webcontents so we can rely on it for popups (Closed)

Created:
3 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Track the original opener of a webcontents so we can rely on it for popups BUG=687572 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2661403003 Cr-Commit-Position: refs/heads/master@{#448116} (cherry picked from commit 6004a36c9e965eedc2b83f2e034bc06afa9dd616) Review-Url: https://codereview.chromium.org/2679513002 . Cr-Commit-Position: refs/branch-heads/2987@{#311} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b50a41a06e9ca097929636e4a1a0e4901bbcafce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -9 lines) Patch
M chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 4 chunks +118 lines, -0 lines 0 comments Download
A chrome/test/data/popup_blocker/popup-window-open-noopener.html View 1 chunk +19 lines, -0 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.h View 2 chunks +16 lines, -0 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 4 chunks +28 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 4 chunks +6 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +15 lines, -3 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
jochen (gone - plz use gerrit)
3 years, 10 months ago (2017-02-05 00:30:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b50a41a06e9ca097929636e4a1a0e4901bbcafce (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698