Track the original opener of a webcontents so we can rely on it for popups

Track the original opener of a webcontents so we can rely on it for popups

BUG=687572
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2661403003
Cr-Commit-Position: refs/heads/master@{#448116}
Committed: https://chromium.googlesource.com/chromium/src/+/6004a36c9e965eedc2b83f2e034bc06afa9dd616

[jochen (gone - plz use gerrit), 2017-02-01 15:33:14]

Description was changed from

==========
Track the original opener of a webcontents so we can rely on it for popups

BUG=687572
==========

to

==========
Track the original opener of a webcontents so we can rely on it for popups

BUG=687572
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jochen (gone - plz use gerrit), 2017-02-01 15:35:14]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 15:35:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-02-01 15:51:05]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 15:51:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 16:27:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 16:27:59]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[jochen (gone - plz use gerrit), 2017-02-01 20:29:10]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 20:29:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 21:07:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 21:07:15]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[jochen (gone - plz use gerrit), 2017-02-01 21:51:32]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 21:52:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-02-01 23:07:28]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 23:07:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-02-01 23:56:04]

jochen@chromium.org changed reviewers:
+ avi@chromium.org

[jochen (gone - plz use gerrit), 2017-02-01 23:56:05]

Avi, can you have a look please?

[commit-bot: I haz the power, 2017-02-02 00:27:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:27:21]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-02-03 19:26:33]

lgtm

https://codereview.chromium.org/2661403003/diff/80001/content/public/browser/...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/2661403003/diff/80001/content/public/browser/...
content/public/browser/web_contents.h:635: // Does this have an opener
associated with it?
You might want to note that this is the "opener" in the JavaScript sense.

https://codereview.chromium.org/2661403003/diff/80001/content/public/browser/...
content/public/browser/web_contents.h:642: // if the opener was suppressed.
... even if the JavaScript opener was suppressed...?

If we can make it clear that "opener" is the JavaScript one, but "original
opener" actually means "the WC that opened this one".

[jochen (gone - plz use gerrit), 2017-02-03 21:17:51]

updated comment

[jochen (gone - plz use gerrit), 2017-02-03 21:18:01]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-02-03 21:18:01]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2661403003/#ps100001
(title: "updates")

[commit-bot: I haz the power, 2017-02-03 21:18:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-02-03 21:42:20]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2017-02-03 21:42:37]

Please fix typos and spacing, then commit. LGTM

https://codereview.chromium.org/2661403003/diff/100001/content/public/browser...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/2661403003/diff/100001/content/public/browser...
content/public/browser/web_contents.h:636: // JavaScript)associated with it?
space after ) plz
typo: corresponding

[jochen (gone - plz use gerrit), 2017-02-03 22:20:14]

thanks for catching! updated

[jochen (gone - plz use gerrit), 2017-02-03 22:20:20]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-02-03 22:20:21]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2661403003/#ps120001
(title: "typo")

[commit-bot: I haz the power, 2017-02-03 22:21:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:11:45]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1486160420987060,
"parent_rev": "75e49223e3dc376c3ee9e7493684034b15fbb73a", "commit_rev":
"6004a36c9e965eedc2b83f2e034bc06afa9dd616"}

[commit-bot: I haz the power, 2017-02-04 00:12:17]

Description was changed from

==========
Track the original opener of a webcontents so we can rely on it for popups

BUG=687572
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Track the original opener of a webcontents so we can rely on it for popups

BUG=687572
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2661403003
Cr-Commit-Position: refs/heads/master@{#448116}
Committed:
https://chromium.googlesource.com/chromium/src/+/6004a36c9e965eedc2b83f2e034b...
==========

[commit-bot: I haz the power, 2017-02-04 00:12:18]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/6004a36c9e965eedc2b83f2e034b...