Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2679423002: ash: Clean up naming of paint-related identifiers (Closed)

Created:
3 years, 10 months ago by enne (OOO)
Modified:
3 years, 10 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, oshima+watch_chromium.org, sadrul, stevenjb+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Clean up naming of paint-related identifiers This is a followup to https://codereview.chromium.org/2640983002 that only changed types. BUG=671433 Review-Url: https://codereview.chromium.org/2679423002 Cr-Commit-Position: refs/heads/master@{#448840} Committed: https://chromium.googlesource.com/chromium/src/+/00bd4b7b6dca660359709fcf49cc00fc10e4ff35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -182 lines) Patch
M ash/autoclick/common/autoclick_ring_handler.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M ash/common/accelerators/debug_commands.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ash/common/accelerators/exit_warning_handler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/common/frame/caption_buttons/frame_caption_button.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M ash/common/frame/default_header_painter.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M ash/common/shelf/app_list_button.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M ash/common/shelf/overflow_button.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ash/common/shelf/shelf_button.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/common/shelf/shelf_widget.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ash/common/system/chromeos/network/network_icon.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/common/system/toast/toast_overlay.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/common/system/tray/tray_background_view.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/common/system/user/rounded_image_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/common/wm/dock/docked_window_layout_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/common/wm/overview/window_grid.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M ash/common/wm/overview/window_selector.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/wm/panels/panel_layout_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/common/wm/window_cycle_list.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/laser/laser_pointer_view.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 3 chunks +21 lines, -21 lines 0 comments Download
M ash/sticky_keys/sticky_keys_overlay.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/touch/touch_hud_debug.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/touch_hud/touch_hud_renderer.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M ash/utility/screenshot_controller.cc View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
enne (OOO)
3 years, 10 months ago (2017-02-07 23:47:35 UTC) #3
Daniel Erat
lgtm thanks for cleaning this up!
3 years, 10 months ago (2017-02-08 00:14:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679423002/1
3 years, 10 months ago (2017-02-08 01:24:53 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 01:39:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00bd4b7b6dca660359709fcf49cc...

Powered by Google App Engine
This is Rietveld 408576698