Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2679413003: Revert of Introduce PushPullFIFO class and remove other FIFOs (Closed)

Created:
3 years, 10 months ago by hongchan
Modified:
3 years, 10 months ago
Reviewers:
haraken, Nico, o1ka, Raymond Toy
CC:
blink-reviews, chromium-reviews, Reid Kleckner
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce PushPullFIFO class and remove other FIFOs (patchset #15 id:340001 of https://codereview.chromium.org/2549093009/ ) Reason for revert: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/12077 Some death tests for CHECK() are failing on the official build. Original issue's description: > This CL is to reduce the complexity of current FIFO structure. > > 1. The simplified PushPullFIFO replaces old FIFOs into one, and removes the > cyclic call structure between AudioDestination and AudioPullFIFO. > 2. This refactoring will be helpful when the new WebThread for AudioWorklet > is implemented. (push and pull operation now can be separated.) > > BUG=678678 > > Review-Url: https://codereview.chromium.org/2549093009 > Cr-Commit-Position: refs/heads/master@{#448784} > Committed: https://chromium.googlesource.com/chromium/src/+/41a5385ea755ea3550ce907716c329b559186a2e TBR=rtoy@chromium.org,olka@chromium.org,haraken@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -648 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDestination.h View 4 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDestination.cpp View 5 chunks +36 lines, -41 lines 0 comments Download
A third_party/WebKit/Source/platform/audio/AudioFIFO.h View 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/audio/AudioFIFO.cpp View 1 chunk +146 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/audio/AudioPullFIFO.h View 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/audio/AudioPullFIFO.cpp View 1 chunk +69 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/platform/audio/PushPullFIFO.h View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/WebKit/Source/platform/audio/PushPullFIFO.cpp View 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp View 1 chunk +0 lines, -364 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hongchan
Created Revert of Introduce PushPullFIFO class and remove other FIFOs
3 years, 10 months ago (2017-02-08 20:13:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679413003/1
3 years, 10 months ago (2017-02-08 20:13:31 UTC) #3
hongchan
FYI. https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/12077
3 years, 10 months ago (2017-02-08 20:14:05 UTC) #4
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/platform/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-08 20:14:16 UTC) #6
Nico
3 years, 10 months ago (2017-02-08 20:22:03 UTC) #7
manually created a revert at https://codereview.chromium.org/2686893002/

Powered by Google App Engine
This is Rietveld 408576698