Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2686893002: Revert "This CL is to reduce the complexity of current FIFO structure." (Closed)

Created:
3 years, 10 months ago by Nico
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, kinuko+watch, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "This CL is to reduce the complexity of current FIFO structure." This reverts https://codereview.chromium.org/2549093009/ since it breaks test in official builds (see comment on review). Manual revert since rietveld failed to revert this > This CL is to reduce the complexity of current FIFO structure. > > 1. The simplified PushPullFIFO replaces old FIFOs into one, and removes the > cyclic call structure between AudioDestination and AudioPullFIFO. > 2. This refactoring will be helpful when the new WebThread for AudioWorklet > is implemented. (push and pull operation now can be separated.) > > BUG=678678 > Review-Url: https://codereview.chromium.org/2549093009 > Cr-Commit-Position: refs/heads/master@{#448784} > Committed: https://chromium.googlesource.com/chromium/src/+/41a5385ea755ea3550ce907716c329b559186a2e NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678678 TBR=hongchan Review-Url: https://codereview.chromium.org/2686893002 Cr-Commit-Position: refs/heads/master@{#449077} Committed: https://chromium.googlesource.com/chromium/src/+/f363ce8f3f7191685f112792ba39721991b7fe60

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -646 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDestination.h View 4 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDestination.cpp View 5 chunks +34 lines, -39 lines 0 comments Download
A third_party/WebKit/Source/platform/audio/AudioFIFO.h View 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/audio/AudioFIFO.cpp View 1 chunk +146 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/audio/AudioPullFIFO.h View 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/audio/AudioPullFIFO.cpp View 1 chunk +69 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/platform/audio/PushPullFIFO.h View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/WebKit/Source/platform/audio/PushPullFIFO.cpp View 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp View 1 chunk +0 lines, -364 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Nico
3 years, 10 months ago (2017-02-08 20:21:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686893002/20001
3 years, 10 months ago (2017-02-08 20:22:28 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-08 20:22:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686893002/20001
3 years, 10 months ago (2017-02-08 20:24:26 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 20:26:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f363ce8f3f7191685f112792ba39...

Powered by Google App Engine
This is Rietveld 408576698