Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2679313002: Update Crashpad to 88442dd5788bf7836ab013939cca4a4683560cb0 (Closed)

Created:
3 years, 10 months ago by Mark Mentovai
Modified:
3 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, mac-reviews_chromium.org, scottmg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to 88442dd5788bf7836ab013939cca4a4683560cb0 3e5ae2dc872a Update comments in IsExceptionNonfatalResource() given 10.12 source 56020daea970 ExceptionTypes test: test “naked” signals 7050c55fca1b Remove LazyInstance usage 948fd2d019cf mac: Report a metric for handler crashes 594eb43b589d mac: Make 64-bit handler able to read 32-bit module lists b638163e7277 Report time zones with no DST transition within a year as not observing 35020d801000 Update buildtools, mini_chromium, gtest, and gyp 88442dd5788b Merge Chromium 294442c0ce05 upstream to Crashpad This also updates the CrashpadMacExceptionCodes histograms.xml enum to contain new values used in Crashpad.HandlerCrash.ExceptionCode.Mac. BUG=crashpad:100, crashpad:120, crashpad:124, crashpad:130, crashpad:148, crashpad:156 Review-Url: https://codereview.chromium.org/2679313002 Cr-Commit-Position: refs/heads/master@{#448755} Committed: https://chromium.googlesource.com/chromium/src/+/fd3cc2e49bac4af931a4d84c5cb41e636e7c2d6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -97 lines) Patch
M third_party/crashpad/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/DEPS View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/handler/handler_main.cc View 5 chunks +129 lines, -7 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_types.h View 4 chunks +13 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc View 2 chunks +27 lines, -40 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_types/dyld_images.proctype View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_types/traits.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc View 2 chunks +37 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac.cc View 2 chunks +23 lines, -11 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac_test.cc View 3 chunks +97 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/exception_types.cc View 1 chunk +20 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/exception_types_test.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/thread/thread_log_messages.cc View 4 chunks +20 lines, -27 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Mark Mentovai
3 years, 10 months ago (2017-02-07 21:11:07 UTC) #3
Robert Sesek
lgtm
3 years, 10 months ago (2017-02-07 21:12:29 UTC) #5
Mark Mentovai
+isherman for histograms.xml
3 years, 10 months ago (2017-02-07 21:18:15 UTC) #7
Ilya Sherman
histograms.xml lgtm
3 years, 10 months ago (2017-02-07 21:35:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679313002/1
3 years, 10 months ago (2017-02-07 21:46:23 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 22:45:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd3cc2e49bac4af931a4d84c5cb4...

Powered by Google App Engine
This is Rietveld 408576698