third_party/crashpad/crashpad/snapshot/mac/process_types/dyld_images.proctype - Issue 2679313002: Update Crashpad to 88442dd5788bf7836ab013939cca4a4683560cb0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/mac/process_types/dyld_images.proctype

Issue 2679313002: Update Crashpad to 88442dd5788bf7836ab013939cca4a4683560cb0 (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/snapshot/mac/process_types/custom.cc ('k') | third_party/crashpad/crashpad/snapshot/mac/process_types/traits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/mac/process_types/dyld_images.proctype

diff --git a/third_party/crashpad/crashpad/snapshot/mac/process_types/dyld_images.proctype b/third_party/crashpad/crashpad/snapshot/mac/process_types/dyld_images.proctype

index eb8410aa402eefc83c256c2d1c30b19e680566b2..3470ee8323a8ded9146e3645c8ce810c4d57c5f8 100644

--- a/third_party/crashpad/crashpad/snapshot/mac/process_types/dyld_images.proctype

+++ b/third_party/crashpad/crashpad/snapshot/mac/process_types/dyld_images.proctype

@@ -123,6 +123,13 @@ PROCESS_TYPE_STRUCT_BEGIN(dyld_all_image_infos)

PROCESS_TYPE_STRUCT_MEMBER(Reserved64_64Only, reserved_6)

PROCESS_TYPE_STRUCT_MEMBER(Reserved64_64Only, reserved_7)

PROCESS_TYPE_STRUCT_MEMBER(Reserved64_64Only, reserved_8)

+ // The 32-bit version of the structure will have four extra bytes of tail

+ // padding when built for 64-bit systems than it does natively and when built

+ // for 32-bit systems. Instead of using sizeof(dyld_all_image_infos), use

+ // offsetof(dyld_all_image_infos, end) to avoid taking this tail padding into

+ // account.

+ PROCESS_TYPE_STRUCT_MEMBER(Nothing, end)

PROCESS_TYPE_STRUCT_END(dyld_all_image_infos)

#endif // ! PROCESS_TYPE_STRUCT_IMPLEMENT_INTERNAL_READ_INTO &&