Wait 5 times long for render process crash callback

Wait 5 times for render process crash callback

The test is flaky on some device because of timeout, wait multiple
times for callback

BUG=689292
Review-Url: https://codereview.chromium.org/2679303002
Cr-Commit-Position: refs/heads/master@{#448855}
Committed: https://chromium.googlesource.com/chromium/src/+/29785ff5f0981c50c14d2df00a099be628641a9e

[michaelbai, 2017-02-07 20:34:26]

michaelbai@chromium.org changed reviewers:
+ sgurun@chromium.org

[michaelbai, 2017-02-07 20:34:32]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 20:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 21:08:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 21:08:31]

Dry run: This issue passed the CQ dry run.

[michaelbai, 2017-02-07 22:09:28]

PTAL

[sgurun-gerrit only, 2017-02-08 00:21:41]

https://codereview.chromium.org/2679303002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
(right):

https://codereview.chromium.org/2679303002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java:76:
helper.waitForCallback(callCount);
instead looping, you can simply set your own timeout. see waitforcallback method
variants.

But I am still not super comfortable with the possibility of a flake.

[michaelbai, 2017-02-08 01:01:08]

https://codereview.chromium.org/2679303002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
(right):

https://codereview.chromium.org/2679303002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java:76:
helper.waitForCallback(callCount);
On 2017/02/08 00:21:41, sgurun wrote:
> instead looping, you can simply set your own timeout. see waitforcallback
method
> variants.
> 
> But I am still not super comfortable with the possibility of a flake. 
> 

Let see if this will fix flaky, otherwise, it might relate to device's
configuration, like prevent crash dialog showing up

[michaelbai, 2017-02-08 01:02:14]

PTAL

[sgurun-gerrit only, 2017-02-08 01:02:35]

lgtm

[michaelbai, 2017-02-08 01:09:12]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:09:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 02:09:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486516152288080,
"parent_rev": "fc09866f18c741c81b93c9314829a3046c724128", "commit_rev":
"29785ff5f0981c50c14d2df00a099be628641a9e"}

[commit-bot: I haz the power, 2017-02-08 02:10:17]

Description was changed from

==========
Wait 5 times for render process crash callback

The test is flaky on some device because of timeout, wait multiple
times for callback

BUG=689292
==========

to

==========
Wait 5 times for render process crash callback

The test is flaky on some device because of timeout, wait multiple
times for callback

BUG=689292

Review-Url: https://codereview.chromium.org/2679303002
Cr-Commit-Position: refs/heads/master@{#448855}
Committed:
https://chromium.googlesource.com/chromium/src/+/29785ff5f0981c50c14d2df00a09...
==========

[commit-bot: I haz the power, 2017-02-08 02:10:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/29785ff5f0981c50c14d2df00a09...