Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2679303002: Wait 5 times long for render process crash callback (Closed)

Created:
3 years, 10 months ago by michaelbai
Modified:
3 years, 10 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wait 5 times for render process crash callback The test is flaky on some device because of timeout, wait multiple times for callback BUG=689292 Review-Url: https://codereview.chromium.org/2679303002 Cr-Commit-Position: refs/heads/master@{#448855} Committed: https://chromium.googlesource.com/chromium/src/+/29785ff5f0981c50c14d2df00a099be628641a9e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Wait 5 times long for render process crash callback #

Patch Set 3 : Wait 5 times long for render process crash callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
michaelbai
3 years, 10 months ago (2017-02-07 20:34:27 UTC) #2
michaelbai
PTAL
3 years, 10 months ago (2017-02-07 22:09:28 UTC) #7
sgurun-gerrit only
https://codereview.chromium.org/2679303002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java (right): https://codereview.chromium.org/2679303002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java#newcode76 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java:76: helper.waitForCallback(callCount); instead looping, you can simply set your own ...
3 years, 10 months ago (2017-02-08 00:21:41 UTC) #8
michaelbai
https://codereview.chromium.org/2679303002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java (right): https://codereview.chromium.org/2679303002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java#newcode76 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java:76: helper.waitForCallback(callCount); On 2017/02/08 00:21:41, sgurun wrote: > instead looping, ...
3 years, 10 months ago (2017-02-08 01:01:08 UTC) #9
michaelbai
PTAL
3 years, 10 months ago (2017-02-08 01:02:14 UTC) #10
sgurun-gerrit only
lgtm
3 years, 10 months ago (2017-02-08 01:02:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679303002/40001
3 years, 10 months ago (2017-02-08 01:09:40 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 02:10:18 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/29785ff5f0981c50c14d2df00a09...

Powered by Google App Engine
This is Rietveld 408576698