Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java

Issue 2679303002: Wait 5 times long for render process crash callback (Closed)
Patch Set: Wait 5 times long for render process crash callback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
index fc5e1504a58edce4a8496dacd0ae43e305d4fb61..a819b6f3b9f10f12f54f90e5f70b19fce4ce22b1 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
@@ -15,10 +15,13 @@ import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.parameter.ParameterizedTest;
+import java.util.concurrent.TimeUnit;
+
/**
* Tests for AwContentsClient.onRenderProcessGone callback.
*/
public class AwContentsClientOnRenderProcessGoneTest extends AwTestBase {
+ private static final String TAG = "AwRendererGone";
private static class GetRenderProcessGoneHelper extends CallbackHelper {
private AwRenderProcessGoneDetail mDetail;
@@ -65,8 +68,8 @@ public class AwContentsClientOnRenderProcessGoneTest extends AwTestBase {
GetRenderProcessGoneHelper helper = contentsClient.getGetRenderProcessGoneHelper();
loadUrlAsync(awContents, "chrome://crash");
int callCount = helper.getCallCount();
- helper.waitForCallback(callCount);
-
+ helper.waitForCallback(callCount, 1, CallbackHelper.WAIT_TIMEOUT_SECONDS * 5,
+ TimeUnit.SECONDS);
assertEquals(callCount + 1, helper.getCallCount());
assertTrue(helper.getAwRenderProcessGoneDetail().didCrash());
assertEquals(RendererPriority.HIGH,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698