Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2679193006: Optimize font fallback for Chinese fonts on Mac (Closed)

Created:
3 years, 10 months ago by eae
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize font fallback for Chinese fonts on Mac Change font fallback on Mac OS X and iOS to prefer higher quality fonts. Prefer system-ui which maps to the default font for each OS version then fall back on a series of fonts in descending order of rendering quality. BUG=642889 R=shrike@chromium.org Review-Url: https://codereview.chromium.org/2679193006 Cr-Commit-Position: refs/heads/master@{#457609} Committed: https://chromium.googlesource.com/chromium/src/+/9b998d1b33fa699e3580e35bc817580706931d13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M ui/strings/app_locale_settings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_ja.xtb View 1 chunk +4 lines, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_ko.xtb View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/strings/translations/app_locale_settings_zh-CN.xtb View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/strings/translations/app_locale_settings_zh-TW.xtb View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
eae
3 years, 10 months ago (2017-02-10 00:11:17 UTC) #5
shrike
I'm not a fonts/fonts fallback expert so I can't vouch for the full correctness, but ...
3 years, 10 months ago (2017-02-10 22:26:43 UTC) #6
eae
+jshin
3 years, 10 months ago (2017-02-21 22:42:10 UTC) #8
jungshik at Google
On 2017/02/21 22:42:10, eae wrote: > +jshin Sorry for the late reply. As long as ...
3 years, 9 months ago (2017-03-01 22:49:34 UTC) #9
eae
On 2017/03/01 22:49:34, jungshik at Google wrote: > On 2017/02/21 22:42:10, eae wrote: > > ...
3 years, 9 months ago (2017-03-01 22:55:01 UTC) #12
kojii
> > BTW, that being the case, do we need any other fonts listed including ...
3 years, 9 months ago (2017-03-02 05:56:14 UTC) #13
eae
Now that 58 has forked should we give this a go?
3 years, 9 months ago (2017-03-08 06:51:18 UTC) #14
jungshik at Google
On 2017/03/08 06:51:18, eae wrote: > Now that 58 has forked should we give this ...
3 years, 9 months ago (2017-03-08 06:54:31 UTC) #15
kojii
I'm fine either way. We can remove it as far as I can think of, ...
3 years, 9 months ago (2017-03-08 07:40:04 UTC) #16
jungshik at Google
> I'm fine either way. We can remove it as far as I can think ...
3 years, 9 months ago (2017-03-16 18:11:51 UTC) #17
eae
On 2017/03/16 18:11:51, jungshik at Google wrote: > > I'm fine either way. We can ...
3 years, 9 months ago (2017-03-16 18:13:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679193006/1
3 years, 9 months ago (2017-03-16 18:14:41 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/410434)
3 years, 9 months ago (2017-03-16 19:47:39 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679193006/1
3 years, 9 months ago (2017-03-16 22:04:07 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 23:49:27 UTC) #27
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b998d1b33fa699e3580e35bc817...

Powered by Google App Engine
This is Rietveld 408576698