[Compiler] Ensure we enter the correct context for compiler-dispatcher jobs.

[Compiler] Ensure we enter the correct context for compiler-dispatcher jobs.

When running main-thread compiler-dispatcher jobs, ensure that we enter the
correct Context. Also adds a test for compiling an extension in the compiler
dispatcher to ensure that idle tasks enter the correct context before
finalizing the compilation.

BUG=v8:5203
Review-Url: https://codereview.chromium.org/2679193004
Cr-Commit-Position: refs/heads/master@{#43111}
Committed: https://chromium.googlesource.com/v8/v8/+/10e628eb1fa613f735b3bd53cd71b386bb1f5786

[rmcilroy, 2017-02-08 18:47:16]

rmcilroy@chromium.org changed reviewers:
+ jochen@chromium.org

[rmcilroy, 2017-02-08 18:47:17]

Jochen, PTAL, thanks.

[jochen (gone - plz use gerrit), 2017-02-08 18:52:58]

lgtm with comments

https://codereview.chromium.org/2679193004/diff/1/test/unittests/compiler-dis...
File test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc (right):

https://codereview.chromium.org/2679193004/diff/1/test/unittests/compiler-dis...
test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc:941: static
const char kExtensionSource[] = "native function Dummy();";
put this (and the class) in an anonymous namespace, then you con't need static

https://codereview.chromium.org/2679193004/diff/1/test/unittests/compiler-dis...
test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc:957: };
disallow copy/assign

[rmcilroy, 2017-02-08 22:49:14]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 22:49:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2017-02-08 22:49:23]

https://codereview.chromium.org/2679193004/diff/1/test/unittests/compiler-dis...
File test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc (right):

https://codereview.chromium.org/2679193004/diff/1/test/unittests/compiler-dis...
test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc:941: static
const char kExtensionSource[] = "native function Dummy();";
On 2017/02/08 18:52:58, jochen wrote:
> put this (and the class) in an anonymous namespace, then you con't need static

Done.

https://codereview.chromium.org/2679193004/diff/1/test/unittests/compiler-dis...
test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc:957: };
On 2017/02/08 18:52:58, jochen wrote:
> disallow copy/assign

Done.

[commit-bot: I haz the power, 2017-02-08 22:59:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 22:59:46]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[rmcilroy, 2017-02-08 23:28:23]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:28:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:36:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:36:39]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[rmcilroy, 2017-02-10 12:26:32]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2017-02-10 12:26:33]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2679193004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-10 12:26:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2017-02-10 12:27:06]

The CQ bit was unchecked by rmcilroy@chromium.org

[rmcilroy, 2017-02-10 16:00:11]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:00:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 16:01:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486742411871350,
"parent_rev": "13042c9a19b58909905da23129ea5445f8e050db", "commit_rev":
"10e628eb1fa613f735b3bd53cd71b386bb1f5786"}

[commit-bot: I haz the power, 2017-02-10 16:01:44]

Description was changed from

==========
[Compiler] Ensure we enter the correct context for compiler-dispatcher jobs.

When running main-thread compiler-dispatcher jobs, ensure that we enter the
correct Context. Also adds a test for compiling an extension in the compiler
dispatcher to ensure that idle tasks enter the correct context before
finalizing the compilation.

BUG=v8:5203
==========

to

==========
[Compiler] Ensure we enter the correct context for compiler-dispatcher jobs.

When running main-thread compiler-dispatcher jobs, ensure that we enter the
correct Context. Also adds a test for compiling an extension in the compiler
dispatcher to ensure that idle tasks enter the correct context before
finalizing the compilation.

BUG=v8:5203

Review-Url: https://codereview.chromium.org/2679193004
Cr-Commit-Position: refs/heads/master@{#43111}
Committed:
https://chromium.googlesource.com/v8/v8/+/10e628eb1fa613f735b3bd53cd71b386bb1...
==========

[commit-bot: I haz the power, 2017-02-10 16:01:45]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/10e628eb1fa613f735b3bd53cd71b386bb1...