Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2679063003: Revert of [regexp] Add stub for RegExpExec instead of inlining (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Igor Sheludko
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Add stub for RegExpExec instead of inlining (patchset #1 id:1 of https://codereview.chromium.org/2677073004/ ) Reason for revert: Doesn't fix perf regressions in crbug.com/688972 and introduces new ones for RegExp in crbug.com/689395. Original issue's description: > [regexp] Add stub for RegExpExec instead of inlining > > The code produced for RegExpExec is quite large, and we ended up completely > inlining it several spots. This CL moves RegExpPrototypeExecBody into two > stubs (one each for fast and slow paths) and converts inlined uses into stub > calls. This decreases the local x64 snapshot size by around 80K. > > BUG=chromium:688972 > > Review-Url: https://codereview.chromium.org/2677073004 > Cr-Commit-Position: refs/heads/master@{#42965} > Committed: https://chromium.googlesource.com/v8/v8/+/5ea144afe3fd98896fc097a3523de9ab0cb8cd61 TBR=yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:688972 Review-Url: https://codereview.chromium.org/2679063003 Cr-Commit-Position: refs/heads/master@{#42985} Committed: https://chromium.googlesource.com/v8/v8/+/7d15175a0f59dfc15cf811a45e358dd4cc9b36e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -65 lines) Patch
M src/builtins/builtins.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 5 chunks +13 lines, -41 lines 0 comments Download
M src/code-factory.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jgruber
Created Revert of [regexp] Add stub for RegExpExec instead of inlining
3 years, 10 months ago (2017-02-07 10:07:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679063003/1
3 years, 10 months ago (2017-02-07 10:07:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/7d15175a0f59dfc15cf811a45e358dd4cc9b36e9
3 years, 10 months ago (2017-02-07 10:08:03 UTC) #6
agrieve
3 years, 10 months ago (2017-02-13 14:55:56 UTC) #7
Message was sent while issue was closed.
On 2017/02/07 10:08:03, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/v8/v8/+/7d15175a0f59dfc15cf811a45e358dd4cc9...

This popped up on Chrome's size graph as a nice 80kb savings! Any chance a
reland will be pursued?

Relevant bug: https://bugs.chromium.org/p/chromium/issues/detail?id=690241

Powered by Google App Engine
This is Rietveld 408576698