Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2677073004: [regexp] Add stub for RegExpExec instead of inlining (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Igor Sheludko
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Add stub for RegExpExec instead of inlining The code produced for RegExpExec is quite large, and we ended up completely inlining it several spots. This CL moves RegExpPrototypeExecBody into two stubs (one each for fast and slow paths) and converts inlined uses into stub calls. This decreases the local x64 snapshot size by around 80K. BUG=chromium:688972 Review-Url: https://codereview.chromium.org/2677073004 Cr-Commit-Position: refs/heads/master@{#42965} Committed: https://chromium.googlesource.com/v8/v8/+/5ea144afe3fd98896fc097a3523de9ab0cb8cd61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -13 lines) Patch
M src/builtins/builtins.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 5 chunks +41 lines, -13 lines 0 comments Download
M src/code-factory.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jgruber
Trying to reduce code size for regexp functions. If required, we could go further by ...
3 years, 10 months ago (2017-02-06 12:44:54 UTC) #4
Yang
On 2017/02/06 12:44:54, jgruber wrote: > Trying to reduce code size for regexp functions. > ...
3 years, 10 months ago (2017-02-06 12:50:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677073004/1
3 years, 10 months ago (2017-02-06 12:54:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/5ea144afe3fd98896fc097a3523de9ab0cb8cd61
3 years, 10 months ago (2017-02-06 12:56:29 UTC) #12
jgruber
3 years, 10 months ago (2017-02-07 10:07:47 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2679063003/ by jgruber@chromium.org.

The reason for reverting is: Doesn't fix perf regressions in crbug.com/688972
and introduces new ones for RegExp in crbug.com/689395..

Powered by Google App Engine
This is Rietveld 408576698