Add gn template for vector icon actions.

Add gn template for vector icon actions.

TBR=tdanderson@chromium.org, pkasting@chromium.org
BUG=626786
Review-Url: https://codereview.chromium.org/2678913002
Cr-Commit-Position: refs/heads/master@{#448674}
Committed: https://chromium.googlesource.com/chromium/src/+/4def64556b77438958e5a4c14e8398c80b216e42

[Evan Stade, 2017-02-06 18:25:55]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-02-06 18:26:15]

estade@chromium.org changed reviewers:
+ thakis@chromium.org

[commit-bot: I haz the power, 2017-02-06 18:26:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-02-06 18:26:48]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 18:26:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-02-06 18:27:37]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 18:27:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 19:48:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 19:48:28]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-02-06 22:35:10]

lgtm, nice!

https://codereview.chromium.org/2678913002/diff/20001/ui/vector_icons/vector_...
File ui/vector_icons/vector_icons.gni (right):

https://codereview.chromium.org/2678913002/diff/20001/ui/vector_icons/vector_...
ui/vector_icons/vector_icons.gni:4: 
add comment that explains what this is and how to use it (cf
https://cs.chromium.org/chromium/src/tools/grit/grit_rule.gni?type=cs&q=templ...
-- especially the dep on the get_outputs() bit of the target

[Evan Stade, 2017-02-07 17:27:41]

Description was changed from

==========
Add gn template for vector icon actions.

BUG=626786
==========

to

==========
Add gn template for vector icon actions.

TBR=tdanderson@chromium.org, pkasting@chromium.org
BUG=626786
==========

[Evan Stade, 2017-02-07 17:27:41]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org, tdanderson@chromium.org

[Evan Stade, 2017-02-07 17:28:54]

TBR pkasting + tdanderson for owned build files:
    ash/resources/vector_icons/BUILD.gn
    components/omnibox/browser/BUILD.gn
    components/toolbar/BUILD.gn

https://codereview.chromium.org/2678913002/diff/20001/ui/vector_icons/vector_...
File ui/vector_icons/vector_icons.gni (right):

https://codereview.chromium.org/2678913002/diff/20001/ui/vector_icons/vector_...
ui/vector_icons/vector_icons.gni:4: 
On 2017/02/06 22:35:10, Nico wrote:
> add comment that explains what this is and how to use it (cf
>
https://cs.chromium.org/chromium/src/tools/grit/grit_rule.gni?type=cs&q=templ...
> -- especially the dep on the get_outputs() bit of the target

Done.

[Evan Stade, 2017-02-07 17:28:57]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-02-07 17:28:58]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2678913002/#ps40001
(title: "docs")

[commit-bot: I haz the power, 2017-02-07 17:29:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 18:28:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486488537669270,
"parent_rev": "8aadc404c56d0cdbc7f89770035af83de6a39561", "commit_rev":
"4def64556b77438958e5a4c14e8398c80b216e42"}

[commit-bot: I haz the power, 2017-02-07 18:29:45]

Description was changed from

==========
Add gn template for vector icon actions.

TBR=tdanderson@chromium.org, pkasting@chromium.org
BUG=626786
==========

to

==========
Add gn template for vector icon actions.

TBR=tdanderson@chromium.org, pkasting@chromium.org
BUG=626786

Review-Url: https://codereview.chromium.org/2678913002
Cr-Commit-Position: refs/heads/master@{#448674}
Committed:
https://chromium.googlesource.com/chromium/src/+/4def64556b77438958e5a4c14e83...
==========

[commit-bot: I haz the power, 2017-02-07 18:29:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4def64556b77438958e5a4c14e83...

[sky, 2017-02-07 20:15:16]

Thanks for coming back to this!

On Tue, Feb 7, 2017 at 10:29 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com>
wrote:
> Committed patchset #3 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/4def64556b77438958e5a4c14e83...
>
> https://codereview.chromium.org/2678913002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Kasting, 2017-02-07 20:22:28]

LGTM