Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: ash/resources/vector_icons/BUILD.gn

Issue 2678913002: Add gn template for vector icon actions. (Closed)
Patch Set: docs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/vector_icons/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/resources/vector_icons/BUILD.gn
diff --git a/ash/resources/vector_icons/BUILD.gn b/ash/resources/vector_icons/BUILD.gn
index 345f17a1ed6477bab406c2ab472e5ae99e9a6815..cf3cee475c004e29564aea055a4578de23a5bc80 100644
--- a/ash/resources/vector_icons/BUILD.gn
+++ b/ash/resources/vector_icons/BUILD.gn
@@ -2,10 +2,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-action("aggregate_vector_icons") {
- visibility = [ ":*" ]
+import("//ui/vector_icons/vector_icons.gni")
- script = "//ui/gfx/vector_icons/aggregate_vector_icons.py"
+aggregate_vector_icons("ash_vector_icons") {
+ icon_directory = "."
icons = [
"ime_menu_emoticon.1x.icon",
@@ -224,36 +224,14 @@ action("aggregate_vector_icons") {
"window_control_right_snapped.1x.icon",
"window_control_right_snapped.icon",
]
-
- output_cc = "$target_gen_dir/vector_icons.cc"
- output_h = "$target_gen_dir/vector_icons.h"
-
- inputs = icons
- inputs += [
- "vector_icons.cc.template",
- "vector_icons.h.template",
- ]
- outputs = [
- output_cc,
- output_h,
- ]
-
- response_file_contents = rebase_path(icons, root_build_dir)
-
- args = [
- "--working_directory=" + rebase_path("./"),
- "--file_list={{response_file_name}}",
- "--output_cc=" + rebase_path(output_cc, root_build_dir),
- "--output_h=" + rebase_path(output_h, root_build_dir),
- ]
}
source_set("vector_icons") {
- sources = get_target_outputs(":aggregate_vector_icons")
+ sources = get_target_outputs(":ash_vector_icons")
sources += [ "//ui/gfx/vector_icon_types.h" ]
deps = [
- ":aggregate_vector_icons",
+ ":ash_vector_icons",
"//base",
"//skia",
]
« no previous file with comments | « no previous file | chrome/app/vector_icons/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698