Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: third_party/WebKit/Source/core/input/MouseEventManager.cpp

Issue 2678683002: Delay instantiating InputDeviceCapabilities until accessed. (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/MouseEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/MouseEventManager.cpp b/third_party/WebKit/Source/core/input/MouseEventManager.cpp
index aaca3de4a6922a173bbbca8e925282d38145c232..3f37ca7b3ad8bd579ce45ac7b7a1351f9914dfeb 100644
--- a/third_party/WebKit/Source/core/input/MouseEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/MouseEventManager.cpp
@@ -19,7 +19,6 @@
#include "core/html/HTMLCanvasElement.h"
#include "core/input/EventHandler.h"
#include "core/input/EventHandlingUtil.h"
-#include "core/input/InputDeviceCapabilities.h"
#include "core/input/KeyboardEventManager.h"
#include "core/layout/HitTestResult.h"
#include "core/layout/api/LayoutViewItem.h"
@@ -395,7 +394,7 @@ Node* MouseEventManager::getNodeUnderMouse() {
WebInputEventResult MouseEventManager::handleMouseFocus(
const HitTestResult& hitTestResult,
- InputDeviceCapabilities* sourceCapabilities) {
+ const InputDeviceCapabilitiesValue& sourceCapabilities) {
// If clicking on a frame scrollbar, do not mess up with content focus.
if (hitTestResult.scrollbar() && !m_frame->contentLayoutItem().isNull()) {
if (hitTestResult.scrollbar()->getScrollableArea() ==
@@ -488,7 +487,8 @@ bool MouseEventManager::slideFocusOnShadowHostIfNecessary(
// Use WebFocusTypeForward instead of WebFocusTypeMouse here to mean the
// focus has slided.
found->focus(FocusParams(SelectionBehaviorOnFocus::Reset,
- WebFocusTypeForward, nullptr));
+ WebFocusTypeForward,
+ InputDeviceCapabilities::Null));
return true;
}
}
« no previous file with comments | « third_party/WebKit/Source/core/input/MouseEventManager.h ('k') | third_party/WebKit/Source/core/page/FocusController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698