Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/WebKit/Source/core/page/FocusController.h

Issue 2678683002: Delay instantiating InputDeviceCapabilities until accessed. (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/FocusController.h
diff --git a/third_party/WebKit/Source/core/page/FocusController.h b/third_party/WebKit/Source/core/page/FocusController.h
index fbe594a847e5c0952411e8b36499b3e98e00ed01..73a9c998ffca93cd4ea6a88bc0c3f105fdd9e591 100644
--- a/third_party/WebKit/Source/core/page/FocusController.h
+++ b/third_party/WebKit/Source/core/page/FocusController.h
@@ -27,6 +27,7 @@
#define FocusController_h
#include "core/CoreExport.h"
+#include "core/input/InputDeviceCapabilities.h"
#include "platform/geometry/LayoutRect.h"
#include "platform/heap/Handle.h"
#include "public/platform/WebFocusType.h"
@@ -43,7 +44,6 @@ class Element;
class FocusChangedObserver;
class Frame;
class HTMLFrameOwnerElement;
-class InputDeviceCapabilities;
class LocalFrame;
class Node;
class Page;
@@ -73,14 +73,15 @@ class CORE_EXPORT FocusController final
bool setInitialFocus(WebFocusType);
bool advanceFocus(WebFocusType type,
- InputDeviceCapabilities* sourceCapabilities = nullptr) {
+ const InputDeviceCapabilitiesValue& sourceCapabilities =
+ InputDeviceCapabilitiesValue()) {
return advanceFocus(type, false, sourceCapabilities);
}
bool advanceFocusAcrossFrames(
WebFocusType,
RemoteFrame* from,
LocalFrame* to,
- InputDeviceCapabilities* sourceCapabilities = nullptr);
+ const InputDeviceCapabilitiesValue& sourceCapabilities);
Element* findFocusableElementInShadowHost(const Element& shadowHost);
bool setFocusedElement(Element*, Frame*, const FocusParams&);
@@ -105,13 +106,13 @@ class CORE_EXPORT FocusController final
bool advanceFocus(WebFocusType,
bool initialFocus,
- InputDeviceCapabilities* sourceCapabilities = nullptr);
+ const InputDeviceCapabilitiesValue&);
bool advanceFocusDirectionally(WebFocusType);
bool advanceFocusInDocumentOrder(LocalFrame*,
Element* start,
WebFocusType,
bool initialFocus,
- InputDeviceCapabilities* sourceCapabilities);
+ const InputDeviceCapabilitiesValue&);
bool advanceFocusDirectionallyInContainer(Node* container,
const LayoutRect& startingRect,
« no previous file with comments | « third_party/WebKit/Source/core/input/MouseEventManager.cpp ('k') | third_party/WebKit/Source/core/page/FocusController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698