Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2678473003: Removed investigation CHECK from didCommitNavigation. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Removed investigation CHECK from didCommitNavigation. This CHECK did not fire. Either because WKNavigation object is nil or because the assumption from crbug.com/676721 was incorrect. BUG=676721 TBR=kknorimoto@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2672673002 Cr-Commit-Position: refs/heads/master@{#448058} (cherry picked from commit c7dda59dad207a6642d7a201e7ed088f3e8bad92) Review-Url: https://codereview.chromium.org/2678473003 Cr-Commit-Position: refs/branch-heads/2987@{#308} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/f09ebb60a6b4cc4e6854bde63c64badc7b9ce576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +0 lines, -10 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678473003/1
3 years, 10 months ago (2017-02-04 03:01:01 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-04 03:01:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678473003/1
3 years, 10 months ago (2017-02-04 03:24:29 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-04 03:24:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678473003/1
3 years, 10 months ago (2017-02-04 03:35:48 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 04:05:49 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f09ebb60a6b4cc4e6854bde63c64...

Powered by Google App Engine
This is Rietveld 408576698