Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Issue 2672673002: Removed investigation CHECK from didCommitNavigation. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed investigation CHECK from didCommitNavigation. This CHECK did not fire. Either because WKNavigation object is nil or because the assumption from crbug.com/676721 was incorrect. BUG=676721 Review-Url: https://codereview.chromium.org/2672673002 Cr-Commit-Position: refs/heads/master@{#448058} Committed: https://chromium.googlesource.com/chromium/src/+/c7dda59dad207a6642d7a201e7ed088f3e8bad92

Patch Set 1 #

Patch Set 2 : Removed unused method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +0 lines, -10 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.mm View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-02 02:40:55 UTC) #3
kkhorimoto
lgtm
3 years, 10 months ago (2017-02-03 19:15:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672673002/10002
3 years, 10 months ago (2017-02-03 19:18:36 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 20:07:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:10002) as
https://chromium.googlesource.com/chromium/src/+/c7dda59dad207a6642d7a201e7ed...

Powered by Google App Engine
This is Rietveld 408576698