Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2678203002: DevTools: extract event_listeners module (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: extract event_listeners module I'll f/u to make event_listeners lazy loaded by element & sources. BUG=687641 Review-Url: https://codereview.chromium.org/2678203002 Cr-Commit-Position: refs/heads/master@{#448558} Committed: https://chromium.googlesource.com/chromium/src/+/42660a6022d49d584415ac90314ee288874b508c

Patch Set 1 #

Patch Set 2 : minor fix #

Patch Set 3 : fix - earlier ps didn't include all changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -929 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js View 1 2 1 chunk +0 lines, -483 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js View 1 2 1 chunk +0 lines, -346 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/eventListenersView.css View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/module.json View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersUtils.js View 1 2 7 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js View 1 2 11 chunks +16 lines, -16 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/event_listeners/eventListenersView.css View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/event_listeners/module.json View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js View 1 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
chenwilliam
ptal
3 years, 10 months ago (2017-02-07 00:26:03 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-07 00:28:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678203002/20001
3 years, 10 months ago (2017-02-07 00:33:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678203002/40001
3 years, 10 months ago (2017-02-07 02:57:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/227099)
3 years, 10 months ago (2017-02-07 04:39:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678203002/40001
3 years, 10 months ago (2017-02-07 05:05:03 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/42660a6022d49d584415ac90314ee288874b508c
3 years, 10 months ago (2017-02-07 05:50:46 UTC) #16
findit-for-me
3 years, 10 months ago (2017-02-07 06:20:46 UTC) #17
Message was sent while issue was closed.
FYI: Findit identified this CL at revision 448558 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Powered by Google App Engine
This is Rietveld 408576698