Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js

Issue 2678203002: DevTools: extract event_listeners module (Closed)
Patch Set: fix - earlier ps didn't include all changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/module.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
diff --git a/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js b/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
index 207a2ca4dd3f703bc3c69148bd59db615293ba36..317185038c919e7ff6eb1fd706dc5ffaf4179527 100644
--- a/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
+++ b/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
@@ -24,16 +24,17 @@ const APPLICATION_DESCRIPTORS = [
const MODULES_TO_REMOVE = [];
const JS_FILES_MAPPING = [
- {file: 'components/NetworkConditionsSelector.js', new: 'network_conditions'},
+ {file: 'components/EventListenersView.js', new: 'event_listeners'},
+ {file: 'components/EventListenersUtils.js', new: 'event_listeners'},
// {file: 'module/file.js', existing: 'module'}
];
const MODULE_MAPPING = {
- network_conditions: {
- dependencies: ['common', 'sdk', 'ui', 'protocol'],
- dependents: ['emulation', 'resources', 'network', 'timeline'],
+ event_listeners: {
+ dependencies: ['ui', 'common', 'components', 'sdk'],
+ dependents: ['elements', 'sources'],
applications: ['inspector.json'],
- autostart: true, // because emulation is autostart
+ autostart: false,
},
};
@@ -73,6 +74,9 @@ function extractModule() {
}, new Map());
const cssFilesMapping = findCSSFiles();
+ // todo: one-off
+ cssFilesMapping.get('components/EventListenersView.js').delete('objectValue.css');
+ console.log('cssFilesMapping', cssFilesMapping);
const identifiersByFile = calculateIdentifiers();
const identifierMap = mapIdentifiers(identifiersByFile, cssFilesMapping);
console.log('identifierMap', identifierMap);
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/module.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698