[Payments] Rename mIsShowingEditDialog to mIsExpandedToFullHeight

Rename mIsShowingEditDialog to mIsExpandedToFullHeight

BUG=687312
Review-Url: https://codereview.chromium.org/2678003004
Cr-Commit-Position: refs/heads/master@{#448388}
Committed: https://chromium.googlesource.com/chromium/src/+/07a62cb56b08816606acc1db1f7c73002aad62ba

[gogerald1, 2017-02-06 18:20:30]

Description was changed from

==========
rename mIsShowingEditDialog

BUG=
==========

to

==========
Rename mIsShowingEditDialog to mIsExpandedToFullHeight

BUG=687312
==========

[gogerald1, 2017-02-06 18:20:36]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 18:21:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-02-06 18:21:44]

gogerald@chromium.org changed reviewers:
+ rouslan@chromium.org

[gogerald1, 2017-02-06 18:21:45]

Hi rouslan@, PTAL,

[please use gerrit instead, 2017-02-06 18:25:24]

lgtm

[commit-bot: I haz the power, 2017-02-06 19:06:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 19:06:39]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2017-02-06 19:29:10]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2017-02-06 19:29:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 19:40:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 19:40:14]

Failed to apply patch for
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:
While running git apply --index -p1;
  error: patch failed:
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:934
  error:
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:
patch does not apply

Patch:      
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
Index:
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
diff --git
a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
index
3be76de87447105a7fa4aac276b5404e4e0f2786..15b1e56412428ca1b57b9ff6a2d0528a79c1f5bd
100644
---
a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
+++
b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
@@ -327,7 +327,7 @@ public class PaymentRequestUI implements
DialogInterface.OnDismissListener, View
     private List<SectionSeparator> mSectionSeparators;
 
     private PaymentRequestSection mSelectedSection;
-    private boolean mIsShowingEditDialog;
+    private boolean mIsExpandedToFullHeight;
     private boolean mIsProcessingPayClicked;
     private boolean mIsClientClosing;
     private boolean mIsClientCheckingSelection;
@@ -834,7 +834,7 @@ public class PaymentRequestUI implements
DialogInterface.OnDismissListener, View
         } else if (v == mPayButton) {
             processPayButton();
         } else if (v == mEditButton) {
-            if (mIsShowingEditDialog) {
+            if (mIsExpandedToFullHeight) {
                 dismissDialog(true);
             } else {
                 expand(mOrderSummarySection);
@@ -934,7 +934,7 @@ public class PaymentRequestUI implements
DialogInterface.OnDismissListener, View
             mButtonBar.setVisibility(View.VISIBLE);
             mSpinnyLayout.setVisibility(View.GONE);
 
-            if (mIsShowingEditDialog) {
+            if (mIsExpandedToFullHeight) {
                 ((FrameLayout.LayoutParams)
mRequestView.getLayoutParams()).height =
                         LayoutParams.MATCH_PARENT;
                 mRequestView.requestLayout();
@@ -984,7 +984,7 @@ public class PaymentRequestUI implements
DialogInterface.OnDismissListener, View
     }
 
     private void expand(PaymentRequestSection section) {
-        if (!mIsShowingEditDialog) {
+        if (!mIsExpandedToFullHeight) {
             // Container now takes the full height of the screen, animating
towards it.
             mRequestView.getLayoutParams().height = LayoutParams.MATCH_PARENT;
             mRequestView.addOnLayoutChangeListener(new
SheetEnlargingAnimator(true));
@@ -1033,7 +1033,7 @@ public class PaymentRequestUI implements
DialogInterface.OnDismissListener, View
                     false /* leftIsSingleLine */, null /* rightTruncate */,
                     false /* rightIsSingleLine */);
 
-            mIsShowingEditDialog = true;
+            mIsExpandedToFullHeight = true;
         }
 
         // Update the section contents when they're selected.

[gogerald1, 2017-02-06 19:53:16]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2017-02-06 19:53:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 19:58:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 19:58:12]

Failed to apply patch for
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:
While running git apply --index -p1;
  error: patch failed:
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:934
  error:
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:
patch does not apply

Patch:      
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
Index:
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
diff --git
a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
index
3be76de87447105a7fa4aac276b5404e4e0f2786..15b1e56412428ca1b57b9ff6a2d0528a79c1f5bd
100644
---
a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
+++
b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
@@ -327,7 +327,7 @@ public class PaymentRequestUI implements
DialogInterface.OnDismissListener, View
     private List<SectionSeparator> mSectionSeparators;
 
     private PaymentRequestSection mSelectedSection;
-    private boolean mIsShowingEditDialog;
+    private boolean mIsExpandedToFullHeight;
     private boolean mIsProcessingPayClicked;
     private boolean mIsClientClosing;
     private boolean mIsClientCheckingSelection;
@@ -834,7 +834,7 @@ public class PaymentRequestUI implements
DialogInterface.OnDismissListener, View
         } else if (v == mPayButton) {
             processPayButton();
         } else if (v == mEditButton) {
-            if (mIsShowingEditDialog) {
+            if (mIsExpandedToFullHeight) {
                 dismissDialog(true);
             } else {
                 expand(mOrderSummarySection);
@@ -934,7 +934,7 @@ public class PaymentRequestUI implements
DialogInterface.OnDismissListener, View
             mButtonBar.setVisibility(View.VISIBLE);
             mSpinnyLayout.setVisibility(View.GONE);
 
-            if (mIsShowingEditDialog) {
+            if (mIsExpandedToFullHeight) {
                 ((FrameLayout.LayoutParams)
mRequestView.getLayoutParams()).height =
                         LayoutParams.MATCH_PARENT;
                 mRequestView.requestLayout();
@@ -984,7 +984,7 @@ public class PaymentRequestUI implements
DialogInterface.OnDismissListener, View
     }
 
     private void expand(PaymentRequestSection section) {
-        if (!mIsShowingEditDialog) {
+        if (!mIsExpandedToFullHeight) {
             // Container now takes the full height of the screen, animating
towards it.
             mRequestView.getLayoutParams().height = LayoutParams.MATCH_PARENT;
             mRequestView.addOnLayoutChangeListener(new
SheetEnlargingAnimator(true));
@@ -1033,7 +1033,7 @@ public class PaymentRequestUI implements
DialogInterface.OnDismissListener, View
                     false /* leftIsSingleLine */, null /* rightTruncate */,
                     false /* rightIsSingleLine */);
 
-            mIsShowingEditDialog = true;
+            mIsExpandedToFullHeight = true;
         }
 
         // Update the section contents when they're selected.

[gogerald1, 2017-02-06 20:36:48]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2017-02-06 20:36:48]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2678003004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-06 20:37:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 21:12:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486413408051170,
"parent_rev": "ee2c2fb24cec1241e84612fa9e104c626e75f565", "commit_rev":
"07a62cb56b08816606acc1db1f7c73002aad62ba"}

[commit-bot: I haz the power, 2017-02-06 21:13:05]

Description was changed from

==========
Rename mIsShowingEditDialog to mIsExpandedToFullHeight

BUG=687312
==========

to

==========
Rename mIsShowingEditDialog to mIsExpandedToFullHeight

BUG=687312

Review-Url: https://codereview.chromium.org/2678003004
Cr-Commit-Position: refs/heads/master@{#448388}
Committed:
https://chromium.googlesource.com/chromium/src/+/07a62cb56b08816606acc1db1f7c...
==========

[commit-bot: I haz the power, 2017-02-06 21:13:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/07a62cb56b08816606acc1db1f7c...