Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3973)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Issue 2678003004: [Payments] Rename mIsShowingEditDialog to mIsExpandedToFullHeight (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
index 5bdcbc66827fc53812053cf70a775b706c83e016..1481faa8cda7d959ef8ae0c5a36659e12f34b81f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
@@ -327,7 +327,7 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
private List<SectionSeparator> mSectionSeparators;
private PaymentRequestSection mSelectedSection;
- private boolean mIsShowingEditDialog;
+ private boolean mIsExpandedToFullHeight;
private boolean mIsProcessingPayClicked;
private boolean mIsClientClosing;
private boolean mIsClientCheckingSelection;
@@ -833,7 +833,7 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
} else if (v == mPayButton) {
processPayButton();
} else if (v == mEditButton) {
- if (mIsShowingEditDialog) {
+ if (mIsExpandedToFullHeight) {
dismissDialog(true);
} else {
expand(mOrderSummarySection);
@@ -930,7 +930,7 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
mCloseButton.setVisibility(View.VISIBLE);
mSpinnyLayout.setVisibility(View.GONE);
- if (mIsShowingEditDialog) {
+ if (mIsExpandedToFullHeight) {
((FrameLayout.LayoutParams) mRequestView.getLayoutParams()).height =
LayoutParams.MATCH_PARENT;
mRequestView.requestLayout();
@@ -980,7 +980,7 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
}
private void expand(PaymentRequestSection section) {
- if (!mIsShowingEditDialog) {
+ if (!mIsExpandedToFullHeight) {
// Container now takes the full height of the screen, animating towards it.
mRequestView.getLayoutParams().height = LayoutParams.MATCH_PARENT;
mRequestView.addOnLayoutChangeListener(new SheetEnlargingAnimator(true));
@@ -1029,7 +1029,7 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
false /* leftIsSingleLine */, null /* rightTruncate */,
false /* rightIsSingleLine */);
- mIsShowingEditDialog = true;
+ mIsExpandedToFullHeight = true;
}
// Update the section contents when they're selected.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698