Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 26780004: Introduce xchgl, orl, roll, subl, testl and xorl into X64 assembler (Closed)

Created:
7 years, 2 months ago by haitao.feng
Modified:
7 years, 2 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Introduce xchgl, orl, roll, subl, testl and xorl into X64 assembler R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -3 lines) Patch
M src/x64/assembler-x64.h View 6 chunks +19 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 3 chunks +27 lines, -1 line 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 2 chunks +153 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
Those instructions are used by X32 only and currently covered by the assembler test case.
7 years, 2 months ago (2013-10-17 08:49:54 UTC) #1
danno
lgtm
7 years, 2 months ago (2013-10-23 13:19:08 UTC) #2
haitao.feng
7 years, 2 months ago (2013-10-24 02:13:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17352 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698