Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2677813002: Revert of Enable HTTP cleartext configuration for Webview (Closed)

Created:
3 years, 10 months ago by dcheng
Modified:
3 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, agrieve+watch_chromium.org, android-webview-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable HTTP cleartext configuration for Webview (patchset #3 id:40001 of https://codereview.chromium.org/2676913002/ ) Reason for revert: Broke the Android chromium builder. http://build.chromium.org/p/chromium/buildstatus?builder=Android&number=67870 Original issue's description: > Enable HTTP cleartext configuration for Webview > > Android platform enabled a mechanism for apps to opt out of cleartext > traffic in Android M. WebView did not participate in this though. > This CL enables applications that are targeting Android O or later > to enable this feature. The actual feature and how apps can > opt out is described in > > https://developer.android.com/training/articles/security-config.html > > The tests for this feature will be added to CTS later. > > BUG=473848 > > Review-Url: https://codereview.chromium.org/2676913002 > Cr-Commit-Position: refs/heads/master@{#448158} > Committed: https://chromium.googlesource.com/chromium/src/+/db5b9203ab60a38348111860ba713970f8c1df92 TBR=boliu@chromium.org,sgurun@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=473848 Review-Url: https://codereview.chromium.org/2677813002 Cr-Commit-Position: refs/heads/master@{#448160} Committed: https://chromium.googlesource.com/chromium/src/+/54e021d3b036d70e5a50d4a74db1238d95f49040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -39 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 2 chunks +2 lines, -7 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java View 2 chunks +0 lines, -5 lines 0 comments Download
M android_webview/native/aw_contents_statics.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dcheng
Created Revert of Enable HTTP cleartext configuration for Webview
3 years, 10 months ago (2017-02-05 00:37:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677813002/1
3 years, 10 months ago (2017-02-05 00:37:14 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-05 00:39:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54e021d3b036d70e5a50d4a74db1...

Powered by Google App Engine
This is Rietveld 408576698