Enable HTTP cleartext configuration for Webview

Enable HTTP cleartext configuration for Webview

Android platform enabled a mechanism for apps to opt out of cleartext
traffic in Android M. WebView did not participate in this though.
This CL enables applications that are targeting Android O or later
to enable this feature. The actual feature and how apps can
opt out is described in

https://developer.android.com/training/articles/security-config.html

The tests for this feature will be added to CTS later.

BUG=473848
Review-Url: https://codereview.chromium.org/2676913002
Cr-Commit-Position: refs/heads/master@{#448158}
Committed: https://chromium.googlesource.com/chromium/src/+/db5b9203ab60a38348111860ba713970f8c1df92

[sgurun-gerrit only, 2017-02-03 23:06:48]

Description was changed from

==========
Enable HTTP cleartext configuration for Webview

Android platform enabled a mechanism for apps to opt out of cleartext
traffic in Android M. WebView did not participate in this though.
This CL enables applications that are targeting Android O or later
to enable this feature. The actual feature and how apps can
opt out is described in

https://developer.android.com/training/articles/security-config.html

The tests for this feature will be added to CTS later.

BUG=473848
==========

to

==========
Enable HTTP cleartext configuration for Webview

Android platform enabled a mechanism for apps to opt out of cleartext
traffic in Android M. WebView did not participate in this though.
This CL enables applications that are targeting Android O or later
to enable this feature. The actual feature and how apps can
opt out is described in

https://developer.android.com/training/articles/security-config.html

The tests for this feature will be added to CTS later.

BUG=473848
==========

[sgurun-gerrit only, 2017-02-03 23:06:48]

sgurun@chromium.org changed reviewers:
+ boliu@chromium.org

[sgurun-gerrit only, 2017-02-03 23:06:57]

On 2017/02/03 23:06:48, sgurun wrote:
> mailto:sgurun@chromium.org changed reviewers:
> + mailto:boliu@chromium.org

ptal, thanks

[boliu, 2017-02-03 23:12:37]

https://codereview.chromium.org/2676913002/diff/1/android_webview/browser/net...
File android_webview/browser/net/aw_url_request_context_getter.cc (right):

https://codereview.chromium.org/2676913002/diff/1/android_webview/browser/net...
android_webview/browser/net/aw_url_request_context_getter.cc:304:
g_check_cleartext_permitted = permitted;
Please DCHECK that this must be called before any AwURLRequestContextGetter is
created

[sgurun-gerrit only, 2017-02-04 00:40:29]

https://codereview.chromium.org/2676913002/diff/1/android_webview/browser/net...
File android_webview/browser/net/aw_url_request_context_getter.cc (right):

https://codereview.chromium.org/2676913002/diff/1/android_webview/browser/net...
android_webview/browser/net/aw_url_request_context_getter.cc:304:
g_check_cleartext_permitted = permitted;
On 2017/02/03 23:12:37, boliu wrote:
> Please DCHECK that this must be called before any AwURLRequestContextGetter is
> created

Done.

[sgurun-gerrit only, 2017-02-04 01:36:34]

On 2017/02/04 00:40:29, sgurun wrote:
>
https://codereview.chromium.org/2676913002/diff/1/android_webview/browser/net...
> File android_webview/browser/net/aw_url_request_context_getter.cc (right):
> 
>
https://codereview.chromium.org/2676913002/diff/1/android_webview/browser/net...
> android_webview/browser/net/aw_url_request_context_getter.cc:304:
> g_check_cleartext_permitted = permitted;
> On 2017/02/03 23:12:37, boliu wrote:
> > Please DCHECK that this must be called before any AwURLRequestContextGetter
is
> > created
> 
> Done.

ptal again. I think it is better to test the whole feature (both negative and
positive) using CTS test so ok with what you suggested.

[boliu, 2017-02-04 01:42:14]

lgtm

[sgurun-gerrit only, 2017-02-04 01:42:34]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2017-02-04 01:42:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sgurun-gerrit only, 2017-02-04 03:20:02]

The CQ bit was unchecked by sgurun@chromium.org

[sgurun-gerrit only, 2017-02-04 03:20:10]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2017-02-04 03:20:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 05:21:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 05:21:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[sgurun-gerrit only, 2017-02-04 13:34:40]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2017-02-04 13:34:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 15:35:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 15:35:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[sgurun-gerrit only, 2017-02-04 23:33:24]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2017-02-04 23:33:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 23:59:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486251204187240,
"parent_rev": "dcc57ec782030dcf6df61f6fcea7c41f0685a516", "commit_rev":
"db5b9203ab60a38348111860ba713970f8c1df92"}

[commit-bot: I haz the power, 2017-02-05 00:01:30]

Description was changed from

==========
Enable HTTP cleartext configuration for Webview

Android platform enabled a mechanism for apps to opt out of cleartext
traffic in Android M. WebView did not participate in this though.
This CL enables applications that are targeting Android O or later
to enable this feature. The actual feature and how apps can
opt out is described in

https://developer.android.com/training/articles/security-config.html

The tests for this feature will be added to CTS later.

BUG=473848
==========

to

==========
Enable HTTP cleartext configuration for Webview

Android platform enabled a mechanism for apps to opt out of cleartext
traffic in Android M. WebView did not participate in this though.
This CL enables applications that are targeting Android O or later
to enable this feature. The actual feature and how apps can
opt out is described in

https://developer.android.com/training/articles/security-config.html

The tests for this feature will be added to CTS later.

BUG=473848

Review-Url: https://codereview.chromium.org/2676913002
Cr-Commit-Position: refs/heads/master@{#448158}
Committed:
https://chromium.googlesource.com/chromium/src/+/db5b9203ab60a38348111860ba71...
==========

[commit-bot: I haz the power, 2017-02-05 00:01:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/db5b9203ab60a38348111860ba71...

[findit-for-me, 2017-02-05 00:19:06]

FYI: Findit identified this CL at revision 448158 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[dcheng, 2017-02-05 00:35:55]

On 2017/02/05 00:19:06, findit-for-me wrote:
> FYI: Findit identified this CL at revision 448158 as the culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

FAILED: obj/android_webview/common/aw_url_request_context_getter.o 
/b/c/cipd/goma/gomacc
../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-MMD -MF obj/android_webview/common/aw_url_request_context_getter.o.d
-DV8_DEPRECATION_WARNINGS -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC
-DUSE_EXTERNAL_POPUP_MENU=1 -DDISABLE_NACL -DSAFE_BROWSING_DB_REMOTE
-DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DENABLE_WEBVR
-DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H
-DANDROID_NDK_VERSION=r12b -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-D_FORTIFY_SOURCE=2 -D__GNU_SOURCE=1 -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_USE_EXTERNAL_STARTUP_DATA -DUSE_EGL
-DDISABLE_FFMPEG_VIDEO_DECODERS -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DU_USING_ICU_NAMESPACE=0
-DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION
-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DSK_IGNORE_DW_GRAY_FIX
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1
-DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DANDROID_NDK_MAJOR_VERSION=12
-DMESA_EGL_NO_X11_HEADERS -I../.. -Igen -I../../third_party/khronos -I../../gpu
-I../../third_party/libwebp -Igen/android_webview -Igen/android_webview
-Igen/android_webview -I../../third_party/protobuf/src -Igen/protoc_out
-I../../third_party/protobuf/src -I../../third_party/ced/src
-I../../third_party/icu/source/common -I../../third_party/icu/source/i18n
-Igen/components -Igen/components -I../../skia/config -I../../skia/ext
-I../../third_party/skia/include/c -I../../third_party/skia/include/config
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/images -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu
-I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl
-I../../breakpad/src -I../../breakpad/src/common/android/include
-Igen/components/metrics/proto -I../../third_party/libwebm/source
-Igen/media/base/android/media_jni_headers
-Igen/media/base/android/media_jni_headers/media
-I../../third_party/boringssl/src/include -Igen -I../../third_party/WebKit
-Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -I../../v8/include
-Igen/v8/include -I../../third_party/mesa/src/include -fno-strict-aliasing
--param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined
-D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe
-ffunction-sections -fno-short-enums -finline-limit=64 -march=armv7-a
-mfloat-abi=softfp -mtune=generic-armv7-a -fno-tree-sra -fno-caller-saves
-mfpu=neon -mthumb -mthumb-interwork -Wall -Werror -Wno-psabi
-Wno-unused-local-typedefs -Wno-maybe-uninitialized
-Wno-missing-field-initializers -Wno-unused-parameter -Os -fno-ident
-fdata-sections -ffunction-sections -fomit-frame-pointer -gdwarf-3 -g1
--sysroot=../../third_party/android_tools/ndk/platforms/android-16/arch-arm
-fvisibility=hidden -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing
-fno-rtti
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include
-isystem../../third_party/android_tools/ndk/sources/android/support/include
-fno-exceptions -c
../../android_webview/browser/net/aw_url_request_context_getter.cc -o
obj/android_webview/common/aw_url_request_context_getter.o
In file included from ../../base/hash.h:16:0,
                 from ../../base/containers/hash_tables.h:13,
                 from ../../base/files/file_path.h:113,
                 from
../../android_webview/browser/net/aw_url_request_context_getter.h:11,
                 from
../../android_webview/browser/net/aw_url_request_context_getter.cc:5:
../../android_webview/browser/net/aw_url_request_context_getter.cc: In static
member function 'static void
android_webview::AwURLRequestContextGetter::set_check_cleartext_permitted(bool)':
../../android_webview/browser/net/aw_url_request_context_getter.cc:311:13:
error: 'g_created_url_request_context_builder' was not declared in this scope
     DCHECK(!g_created_url_request_context_builder);
             ^
../../base/logging.h:766:54: note: in definition of macro 'DCHECK'
 #define DCHECK(condition) EAT_STREAM_PARAMETERS << !(condition)

[dcheng, 2017-02-05 00:37:03]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2677813002/ by dcheng@chromium.org.

The reason for reverting is: Broke the Android chromium builder.
http://build.chromium.org/p/chromium/buildstatus?builder=Android&number=67870.