Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2677793003: Don't initialize event when calling create() with no argument (Closed)

Created:
3 years, 10 months ago by Sunny
Modified:
3 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, haraken, rwlbuis, sof, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't initialize event when calling create() with no argument "BeforeUnloadEvent", "CloseEvent" and "PopStateEvent" initialized too early when created with document.createEvent, cause they have default "type" attribute unexpectedly. Tests were changed accordingly BUG=684851 Review-Url: https://codereview.chromium.org/2677793003 Cr-Commit-Position: refs/heads/master@{#448515} Committed: https://chromium.googlesource.com/chromium/src/+/39d843f8a5df7d463c3a14b4fe493e19db91c87e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/dom/events/EventTarget-dispatchEvent-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/BeforeUnloadEvent.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/PopStateEvent.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/CloseEvent.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Sunny
Hi tkent@, please take a look, thanks~
3 years, 10 months ago (2017-02-04 17:03:14 UTC) #2
Sunny
Hi tkent@ Seems test 'EncryptedMediaTest.FrameSizeChangeVideo' was failed in cast_shell_linux, but I've checked the buildbot history ...
3 years, 10 months ago (2017-02-06 06:04:37 UTC) #7
tkent
lgtm
3 years, 10 months ago (2017-02-06 23:34:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677793003/1
3 years, 10 months ago (2017-02-06 23:35:22 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 02:20:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/39d843f8a5df7d463c3a14b4fe49...

Powered by Google App Engine
This is Rietveld 408576698