third_party/WebKit/Source/core/dom/Document.cpp - Issue 2677793003: Don't initialize event when calling create() with no argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2677793003: Don't initialize event when calling create() with no argument (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 6643b522c8654e18c93e0e3822dd875ca377a551..b20ac07afa56e29a5f143b6b438998b627a40ab5 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -2971,6 +2971,7 @@ bool Document::dispatchBeforeUnloadEvent(ChromeClient& chromeClient,

return false;

BeforeUnloadEvent* beforeUnloadEvent = BeforeUnloadEvent::create();

+ beforeUnloadEvent->initEvent(EventTypeNames::beforeunload, false, true);

m_loadEventProgress = BeforeUnloadEventInProgress;

m_domWindow->dispatchEvent(beforeUnloadEvent, this);

m_loadEventProgress = BeforeUnloadEventCompleted;