Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2677703002: Catches and ignores errors when accessing win.document in Password Autofill JS (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Catches and ignores errors when accessing win.document in Password Autofill JS Old implementation assumes that win.document will silently return nil. Under some versions of iOS, access to win.document may generate an exception, thus the try/catch. BUG=685761 Review-Url: https://codereview.chromium.org/2661503003 Cr-Commit-Position: refs/heads/master@{#447228} (cherry picked from commit ea5098bb3372baa8d32b117f1b687e739e075988) Review-Url: https://codereview.chromium.org/2677703002 . Cr-Commit-Position: refs/branch-heads/2987@{#293} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/afa15792ff95c1cd79b83115198bd5e4be74ab2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ios/chrome/browser/passwords/resources/password_controller.js View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-03 18:24:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
afa15792ff95c1cd79b83115198bd5e4be74ab2d.

Powered by Google App Engine
This is Rietveld 408576698