Catches and ignores errors when accessing win.document in Password Autofill JS

Catches and ignores errors when accessing win.document in Password Autofill JS

Old implementation assumes that win.document will silently return nil.
Under some versions of iOS, access to win.document may generate an
exception, thus the try/catch.

BUG=685761
Review-Url: https://codereview.chromium.org/2661503003
Cr-Commit-Position: refs/heads/master@{#447228}
Committed: https://chromium.googlesource.com/chromium/src/+/ea5098bb3372baa8d32b117f1b687e739e075988

[pkl (ping after 24h if needed), 2017-01-27 02:39:54]

Description was changed from

==========
.

BUG=
==========

to

==========
Catches and ignores errors when accessing win.document in Password Autofill JS

Old implementation assumes that win.document will silently return nil.
Under some versions of iOS, access to win.document may generate an
exception, thus the try/catch.

BUG=685761
==========

[pkl (ping after 24h if needed), 2017-01-27 02:40:17]

pkl@chromium.org changed reviewers:
+ melandory@chromium.org

[pkl (ping after 24h if needed), 2017-01-27 02:40:20]

PTAL. Thanks!

[pkl (ping after 24h if needed), 2017-01-27 02:47:17]

pkl@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2017-01-27 17:04:38]

LGTM

[pkl (ping after 24h if needed), 2017-01-27 17:06:21]

The CQ bit was checked by pkl@chromium.org

[commit-bot: I haz the power, 2017-01-27 17:06:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 17:15:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 17:15:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pkl (ping after 24h if needed), 2017-01-27 17:58:54]

Waiting for OWNERS review from melandory

[pkl (ping after 24h if needed), 2017-01-30 14:36:29]

melandory: Gentle ping for OWNERS review.

[melandory, 2017-01-31 11:39:57]

On 2017/01/30 14:36:29, pklpkl wrote:
> melandory: Gentle ping for OWNERS review.

lgtm, sorry for delay was ooo

[pkl (ping after 24h if needed), 2017-01-31 14:02:20]

The CQ bit was checked by pkl@chromium.org

[commit-bot: I haz the power, 2017-01-31 14:02:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 14:12:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485871340436610,
"parent_rev": "f81b1e4663392c62f61654abe3e3dfd0690efab0", "commit_rev":
"ea5098bb3372baa8d32b117f1b687e739e075988"}

[commit-bot: I haz the power, 2017-01-31 14:12:38]

Description was changed from

==========
Catches and ignores errors when accessing win.document in Password Autofill JS

Old implementation assumes that win.document will silently return nil.
Under some versions of iOS, access to win.document may generate an
exception, thus the try/catch.

BUG=685761
==========

to

==========
Catches and ignores errors when accessing win.document in Password Autofill JS

Old implementation assumes that win.document will silently return nil.
Under some versions of iOS, access to win.document may generate an
exception, thus the try/catch.

BUG=685761

Review-Url: https://codereview.chromium.org/2661503003
Cr-Commit-Position: refs/heads/master@{#447228}
Committed:
https://chromium.googlesource.com/chromium/src/+/ea5098bb3372baa8d32b117f1b68...
==========

[commit-bot: I haz the power, 2017-01-31 14:12:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ea5098bb3372baa8d32b117f1b68...