Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2677603003: Move DeviceMotion and DeviceOrientation out from fast/dom/. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
timvolodine
CC:
blink-reviews, chromium-reviews, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DeviceMotion and DeviceOrientation out from fast/dom/. They are not parts of DOM. https://www.w3.org/TR/orientation-event/ defines them. So they should be moved to LayoutTests/orientation-event/. This CL has no behavior changes. BUG=685886 R=timvolodine@chromium.org Review-Url: https://codereview.chromium.org/2677603003 Cr-Commit-Position: refs/heads/master@{#449114} Committed: https://chromium.googlesource.com/chromium/src/+/f9e95155715b4be3e9ad4f67a9d74144ddd1853b

Patch Set 1 #

Patch Set 2 : device_orientation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1852 lines) Patch
M WATCHLISTS View 1 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/add-during-dispatch.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/add-during-dispatch-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/add-listener-from-callback.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/add-listener-from-callback-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/create-event.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/create-event-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/fire-last-event.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/fire-last-event-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/multiple-event-listeners.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/multiple-event-listeners-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/null-values.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/null-values-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/page-visibility.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/page-visibility-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/window-property.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/motion/window-property-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/add-listener-from-callback.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/add-listener-from-callback-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/basic-operation.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/basic-operation-absolute.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/basic-operation-absolute-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/basic-operation-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/create-event.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/create-event-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/multiple-event-listeners.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/multiple-event-listeners-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/multiple-frames.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/multiple-frames-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/no-synchronous-events.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/no-synchronous-events-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/null-values.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/null-values-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/page-visibility.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/page-visibility-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/resources/basic-operation.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/updates.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/updates-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/window-property.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/device_orientation/orientation/window-property-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/add-during-dispatch.html View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/add-during-dispatch-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/add-listener-from-callback.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/add-listener-from-callback-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/create-event.html View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/create-event-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/fire-last-event.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/fire-last-event-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/multiple-event-listeners.html View 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/multiple-event-listeners-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/null-values.html View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/null-values-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/optional-event-properties.html View 1 chunk +0 lines, -126 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/optional-event-properties-expected.txt View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/page-visibility.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/page-visibility-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/window-property.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceMotion/window-property-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/add-listener-from-callback.html View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/add-listener-from-callback-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/basic-operation.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/basic-operation-absolute.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/basic-operation-absolute-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/basic-operation-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/create-event.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/create-event-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/multiple-event-listeners.html View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/multiple-event-listeners-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/multiple-frames.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/multiple-frames-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/no-synchronous-events.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/no-synchronous-events-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/null-values.html View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/null-values-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/optional-event-properties.html View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/optional-event-properties-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/page-visibility.html View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/page-visibility-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/resources/basic-operation.js View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/updates.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/updates-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/window-property.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/DeviceOrientation/window-property-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
tkent
timvolodine@, would you review this please? My goal is to remove fast/dom/.
3 years, 10 months ago (2017-02-03 12:13:29 UTC) #5
timvolodine
On 2017/02/03 12:13:29, tkent wrote: > timvolodine@, would you review this please? > > My ...
3 years, 10 months ago (2017-02-03 18:42:00 UTC) #6
tkent
On 2017/02/03 at 18:42:00, timvolodine wrote: > I see, thanks. Would the "orientation-event" naming clash ...
3 years, 10 months ago (2017-02-07 01:02:43 UTC) #9
timvolodine
On 2017/02/07 01:02:43, tkent wrote: > On 2017/02/03 at 18:42:00, timvolodine wrote: > > I ...
3 years, 10 months ago (2017-02-08 16:52:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677603003/20001
3 years, 10 months ago (2017-02-08 21:12:41 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 22:44:38 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f9e95155715b4be3e9ad4f67a9d7...

Powered by Google App Engine
This is Rietveld 408576698