[Local NTP] Cleanup: Remove a bunch of dead code

[Local NTP] Cleanup: Remove a bunch of dead code

BUG=687972
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2677513002
Cr-Commit-Position: refs/heads/master@{#448241}
Committed: https://chromium.googlesource.com/chromium/src/+/da2998f849650a5ebfb547d962076f80dcbef19b

[Marc Treib, 2017-02-02 17:46:32]

Description was changed from

==========
[Local NTP] Cleanup: Remove a bunch of dead code

BUG=687972
==========

to

==========
[Local NTP] Cleanup: Remove a bunch of dead code

BUG=687972
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Marc Treib, 2017-02-02 17:46:42]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 17:47:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 19:56:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 19:56:44]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-02-03 09:16:58]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[Marc Treib, 2017-02-03 09:16:59]

aaand another one. PTAL!

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
File chrome/browser/resources/local_ntp/local_ntp.js (left):

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.js:224: var fakeboxInputBehavior =
NTP_DISPOSE_STATE.HIDE_FAKEBOX_AND_LOGO;
These two were effectively constants. I just inlined the values below, which
exposed some more simplification.

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.js:427: function
convertToRRGGBBAAColor(color) {
Never called

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.js:571: disposeNtp(false);
disposeNtp(false) didn't do anything, see below

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.js:582: if (behavior ==
NTP_DISPOSE_STATE.DISABLE_FAKEBOX)
This could never happen (DISABLE_FAKEBOX is unused).

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.js:585:
setFakeboxAndLogoVisibility(false);
This was inlined in onInputStart

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.js:593: setFakeboxActive(true);
Pointless, because it's never called with false

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.js:635:
!document.body.classList.contains(CLASSES.FAKEBOX_DISABLE);
This class is never set

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.js:652: function $(id) {
There's an exact duplicate above

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.js:665: function
createAndAppendElement(parent, name, opt_class) {
There was only one caller, which turned out to be completely pointless

https://codereview.chromium.org/2677513002/diff/1/chrome/browser/resources/lo...
chrome/browser/resources/local_ntp/local_ntp.js:771: notificationCloseButton,
'div', CLASSES.BLACKLIST_BUTTON_INNER);
No idea what this was supposed to do. The class doesn't even exist, so all this
did was append an empty div.

[Marc Treib, 2017-02-06 09:14:46]

Ping!

[sfiera, 2017-02-06 10:05:37]

LGTM

[Marc Treib, 2017-02-06 11:10:14]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 11:10:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 12:08:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 12:08:07]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-02-06 13:40:43]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2017-02-06 13:41:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 13:47:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486388443846800, "parent_rev":
"1062d8b23ec8d82de3444e6a7a9a5256bfcfe6e2", "commit_rev":
"da2998f849650a5ebfb547d962076f80dcbef19b"}

[commit-bot: I haz the power, 2017-02-06 13:47:47]

Description was changed from

==========
[Local NTP] Cleanup: Remove a bunch of dead code

BUG=687972
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Local NTP] Cleanup: Remove a bunch of dead code

BUG=687972
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2677513002
Cr-Commit-Position: refs/heads/master@{#448241}
Committed:
https://chromium.googlesource.com/chromium/src/+/da2998f849650a5ebfb547d96207...
==========

[commit-bot: I haz the power, 2017-02-06 13:47:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da2998f849650a5ebfb547d96207...