Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 2670123003: [Local NTP] Cleanup: Remove support for "icons" layout (Closed)

Created:
3 years, 10 months ago by Marc Treib
Modified:
3 years, 10 months ago
Reviewers:
sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Local NTP] Cleanup: Remove support for "icons" layout BUG=687972 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2670123003 Cr-Commit-Position: refs/heads/master@{#448238} Committed: https://chromium.googlesource.com/chromium/src/+/a54b01488c10b495753a6fc15363309a523052b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -73 lines) Patch
M chrome/browser/resources/local_ntp/local_ntp.css View 2 chunks +3 lines, -29 lines 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp.js View 7 chunks +2 lines, -28 lines 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
Marc Treib
PTAL!
3 years, 10 months ago (2017-02-02 17:44:24 UTC) #5
Marc Treib
Ping!
3 years, 10 months ago (2017-02-06 09:14:34 UTC) #12
sfiera
LGTM
3 years, 10 months ago (2017-02-06 09:56:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670123003/1
3 years, 10 months ago (2017-02-06 10:35:42 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/112974)
3 years, 10 months ago (2017-02-06 11:53:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670123003/1
3 years, 10 months ago (2017-02-06 12:22:18 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 13:34:17 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a54b01488c10b495753a6fc15363...

Powered by Google App Engine
This is Rietveld 408576698