Convert WaveShaper tests to testharness

Convert WaveShaper tests to testharness

Manually update tests to use testharness and new Audit.

BUG=688497
TEST=

Review-Url: https://codereview.chromium.org/2677453005
Cr-Commit-Position: refs/heads/master@{#452191}
Committed: https://chromium.googlesource.com/chromium/src/+/ff7f74159c5acab2a088a34c78b8f68283be8361

[Raymond Toy, 2017-02-21 17:52:33]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-21 17:52:34]

PTAL

[hongchan, 2017-02-22 19:05:35]

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits.html
(right):

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits.html:56: 
An empty line.

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits.html:67:
task.describe("Test WaveShaperNode including values outside the range of
[-1,1]");
Hmm. Should we try to land this after the 'task.describe' change?

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits.html:94:
.then(task.done.bind(task));
() => task.done()

We should move away from .bind() pattern from now on.

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper.html (right):

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper.html:114:
.then(task.done.bind(task));
() => task.done()

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js
(right):

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js:143:
task.describe(testParams.description);
Ditto. How do we reconcile this with task.describe() CL?

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js:165:
.then(task.done.bind(task));
() => task.done()

[Raymond Toy, 2017-02-22 19:23:24]

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits.html
(right):

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits.html:67:
task.describe("Test WaveShaperNode including values outside the range of
[-1,1]");
On 2017/02/22 19:05:34, hongchan wrote:
> Hmm. Should we try to land this after the 'task.describe' change?

Yes. I'll wait and then rebase this.

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits.html:94:
.then(task.done.bind(task));
On 2017/02/22 19:05:34, hongchan wrote:
> () => task.done()
> 
> We should move away from .bind() pattern from now on.

Done.

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js
(right):

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js:143:
task.describe(testParams.description);
On 2017/02/22 19:05:35, hongchan wrote:
> Ditto. How do we reconcile this with task.describe() CL?

Wait until that's landed.

https://codereview.chromium.org/2677453005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js:165:
.then(task.done.bind(task));
On 2017/02/22 19:05:35, hongchan wrote:
> () => task.done()

Done.

[hongchan, 2017-02-22 19:24:13]

lgtm

[Raymond Toy, 2017-02-22 19:29:02]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-02-22 19:29:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 20:51:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487791742794450,
"parent_rev": "e18b88a5d18f93520fe9e97851e14582b0eb5e50", "commit_rev":
"ff7f74159c5acab2a088a34c78b8f68283be8361"}

[commit-bot: I haz the power, 2017-02-22 20:52:29]

Description was changed from

==========
Convert WaveShaper tests to testharness

Manually update tests to use testharness and new Audit.

BUG=688497
TEST=
==========

to

==========
Convert WaveShaper tests to testharness

Manually update tests to use testharness and new Audit.

BUG=688497
TEST=

Review-Url: https://codereview.chromium.org/2677453005
Cr-Commit-Position: refs/heads/master@{#452191}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff7f74159c5acab2a088a34c78b8...
==========

[commit-bot: I haz the power, 2017-02-22 20:52:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ff7f74159c5acab2a088a34c78b8...