Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits.html

Issue 2677453005: Convert WaveShaper tests to testharness (Closed)
Patch Set: Clean up and remove results files Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper.html ('K') | « third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits-expected.txt » ('j') | third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> 1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
2 <html> 2 <html>
3 <head> 3 <head>
4 <script src="../../resources/js-test.js"></script> 4 <script src="../../resources/testharness.js"></script>
5 <script src="../../resources/testharnessreport.js"></script>
6 <script src="../resources/audit-util.js"></script>
7 <script src="../resources/audit.js"></script>
5 </head> 8 </head>
6 9
7 <body> 10 <body>
8 <div id="description"></div>
9 <div id="console"></div>
10
11 <script> 11 <script>
12 description("Test WaveShaperNode including values outside the range of [-1 ,1]"); 12 var audit = Audit.createTaskRunner();
13 13
14 var context; 14 var context;
15 var bufferData; 15 var bufferData;
16 var outputData; 16 var outputData;
17 var reference; 17 var reference;
18 18
19 var sampleRate = 48000; 19 var sampleRate = 48000;
20 // Must be odd so we have an exact middle point. 20 // Must be odd so we have an exact middle point.
21 var testFrames = 23; 21 var testFrames = 23;
22 var scale = 1 / ((testFrames - 1) / 2 - 1); 22 var scale = 1 / ((testFrames - 1) / 2 - 1);
(...skipping 18 matching lines...) Expand all
41 ref[midPoint] = 1; 41 ref[midPoint] = 1;
42 // Generate a ramp from 1 down to 0 42 // Generate a ramp from 1 down to 0
43 for (var k = midPoint; k < testFrames - 1; ++k) { 43 for (var k = midPoint; k < testFrames - 1; ++k) {
44 ref[k + 1] = 2 - k * scale; 44 ref[k + 1] = 2 - k * scale;
45 } 45 }
46 // The last sample is out of range at 1+scale 46 // The last sample is out of range at 1+scale
47 ref[testFrames - 1] = 0; 47 ref[testFrames - 1] = 0;
48 return ref; 48 return ref;
49 } 49 }
50 50
51 function checkResult (event) { 51 function checkResult (renderedBuffer, should) {
52 outputData = event.renderedBuffer.getChannelData(0); 52 outputData = renderedBuffer.getChannelData(0);
53 reference = generateReference(); 53 reference = generateReference();
54 var success = true; 54 var success = true;
55 // Verify that every output value matches our expected reference value. 55 // Verify that every output value matches our expected reference value.
56
hongchan 2017/02/22 19:05:35 An empty line.
56 for (var k = 0; k < outputData.length; ++k) { 57 for (var k = 0; k < outputData.length; ++k) {
57 var diff = outputData[k] - reference[k]; 58 var diff = outputData[k] - reference[k];
58 if (Math.abs(diff) <= diffThreshold) { 59 should(Math.abs(diff),
59 testPassed(bufferData[k].toFixed(decimals) + " -> " + outputData[k ].toFixed(decimals) + "."); 60 "Max error mapping " + bufferData[k].toFixed(decimals) + " to " +
60 } else { 61 outputData[k].toFixed(decimals))
61 testFailed(bufferData[k].toFixed(decimals) + " -> " + outputData[k ].toFixed(decimals) + ", but expected " + reference[k].toFixed(decimals) + "."); 62 .beLessThanOrEqualTo(diffThreshold);
62 success = false;
63 }
64 } 63 }
65
66 if (success)
67 testPassed("All outputs matched expected results.");
68 else
69 testFailed("Some outputs did not match expected results.");
70
71 finishJSTest();
72 } 64 }
73 65
74 function runTest () { 66 audit.define("test", function (task, should) {
75 if (window.testRunner) { 67 task.describe("Test WaveShaperNode including values outside the range of [-1,1]");
hongchan 2017/02/22 19:05:34 Hmm. Should we try to land this after the 'task.de
Raymond Toy 2017/02/22 19:23:24 Yes. I'll wait and then rebase this.
76 testRunner.dumpAsText();
77 testRunner.waitUntilDone();
78 }
79
80 window.jsTestIsAsync = true;
81
82 context = new OfflineAudioContext(1, testFrames, sampleRate); 68 context = new OfflineAudioContext(1, testFrames, sampleRate);
83 // Create input values between -1.1 and 1.1 69 // Create input values between -1.1 and 1.1
84 var buffer = context.createBuffer(1, testFrames, context.sampleRate); 70 var buffer = context.createBuffer(1, testFrames, context.sampleRate);
85 bufferData = buffer.getChannelData(0); 71 bufferData = buffer.getChannelData(0);
86 var start = -1 - scale; 72 var start = -1 - scale;
87 for (var k = 0; k < testFrames; ++k) { 73 for (var k = 0; k < testFrames; ++k) {
88 bufferData[k] = k * scale + start; 74 bufferData[k] = k * scale + start;
89 } 75 }
90 76
91 var source = context.createBufferSource(); 77 var source = context.createBufferSource();
92 source.buffer = buffer; 78 source.buffer = buffer;
93 79
94 // Create simple waveshaper. It should map -1 to 0, 0 to 1, and +1 to 0 and interpolate 80 // Create simple waveshaper. It should map -1 to 0, 0 to 1, and +1 to 0 and interpolate
95 // all points in between using a simple linear interpolator. 81 // all points in between using a simple linear interpolator.
96 var shaper = context.createWaveShaper(); 82 var shaper = context.createWaveShaper();
97 var curve = new Float32Array(3); 83 var curve = new Float32Array(3);
98 curve[0] = 0; 84 curve[0] = 0;
99 curve[1] = 1; 85 curve[1] = 1;
100 curve[2] = 0; 86 curve[2] = 0;
101 shaper.curve = curve; 87 shaper.curve = curve;
102 source.connect(shaper); 88 source.connect(shaper);
103 shaper.connect(context.destination); 89 shaper.connect(context.destination);
104 90
105 source.start(); 91 source.start();
106 context.oncomplete = checkResult; 92 context.startRendering()
107 context.startRendering(); 93 .then(buffer => checkResult(buffer, should))
108 } 94 .then(task.done.bind(task));
hongchan 2017/02/22 19:05:34 () => task.done() We should move away from .bind(
Raymond Toy 2017/02/22 19:23:24 Done.
95 });
109 96
110 runTest(); 97 audit.run();
111 successfullyParsed = true;
112 </script> 98 </script>
113 </body> 99 </body>
114 </html> 100 </html>
OLDNEW
« third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper.html ('K') | « third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits-expected.txt » ('j') | third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698