Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2677003004: MD Settings: Make Protected Content setting available to all platforms. (Closed)

Created:
3 years, 10 months ago by tommycli
Modified:
3 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Make Protected Content setting available to all platforms. The Protected Content setting has been re-designed to toggle DRM on all platforms. This makes the setting available on all platforms. This also updates the string to the new text. MD Settings equivalent to this patch: https://codereview.chromium.org/2679723003/ BUG=687783, 686886 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2677003004 Cr-Commit-Position: refs/heads/master@{#448680} Committed: https://chromium.googlesource.com/chromium/src/+/45f66398546e5f402fb9768e05c1321893dbee6b

Patch Set 1 #

Patch Set 2 : Merge branch 'master' of https://chromium.googlesource.com/chromium/src into 399-settings-make-enab… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/route.js View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings_page/site_settings_page.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
tommycli
stevenjb: PTAL, thanks!
3 years, 10 months ago (2017-02-07 00:18:18 UTC) #6
stevenjb
3 years, 10 months ago (2017-02-07 00:22:46 UTC) #7
stevenjb
lgtm
3 years, 10 months ago (2017-02-07 00:22:52 UTC) #8
tommycli
On 2017/02/07 00:22:52, stevenjb wrote: > lgtm thanks!
3 years, 10 months ago (2017-02-07 00:34:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677003004/1
3 years, 10 months ago (2017-02-07 00:34:46 UTC) #12
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/settings/privacy_page/privacy_page.html: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-07 01:26:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677003004/20001
3 years, 10 months ago (2017-02-07 17:47:15 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/45f66398546e5f402fb9768e05c1321893dbee6b
3 years, 10 months ago (2017-02-07 18:55:14 UTC) #20
Will Harris
the bug for this is crbug.com/686886 I think?
3 years, 10 months ago (2017-02-07 18:59:12 UTC) #21
tommycli
3 years, 10 months ago (2017-02-07 19:40:40 UTC) #23
Message was sent while issue was closed.
On 2017/02/07 18:59:12, Will Harris wrote:
> the bug for this is crbug.com/686886 I think?

Ah, that's right. I updated the bug numbers.

Powered by Google App Engine
This is Rietveld 408576698