Settings: Make Enable DRM checkbox available on all platforms

Settings: Make Enable DRM checkbox available on all platforms

This CL affects Old Options (not MD) and does two things:
 1. Updates strings to reflect that this checkbox toggles DRM entirely.
 2. Makes this checkbox available to all platforms.

It doesn't touch MD Settings for M57 merge-ability reasons.

BUG=686430
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[tommycli, 2017-02-06 20:44:25]

Description was changed from

==========
Settings: Update Protected Content strings to match desired behavior.

Since we're making this checkbox disable DRM entirely, update the
strings to match behavior.

BUG=686430
==========

to

==========
Settings: Update Protected Content strings to match desired behavior.

Since we're making this checkbox disable DRM entirely, update the
strings to match behavior.

BUG=686430
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-02-06 20:46:47]

Description was changed from

==========
Settings: Update Protected Content strings to match desired behavior.

Since we're making this checkbox disable DRM entirely, update the
strings to match behavior.

BUG=686430
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Make Enable DRM checkbox available on all platforms

This CL affects Old Options (not MD) and does two things:
 1. Updates strings to reflect that this checkbox toggles DRM entirely.
 2. Makes this checkbox available to all platforms.

It doesn't touch MD Settings for M57 merge-ability reasons.

BUG=686430
==========

[tommycli, 2017-02-06 20:47:35]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 20:48:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 21:47:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 21:47:25]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-02-06 21:55:56]

tommycli@chromium.org changed reviewers:
+ srahim@chromium.org, stevenjb@chromium.org

[tommycli, 2017-02-06 21:55:58]

srahim, stevenjb: PTAL, screneshot here:

http://imgur.com/a/IhrsT

[stevenjb, 2017-02-07 21:43:52]

https://codereview.chromium.org/2679723003/diff/10003/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

https://codereview.chromium.org/2679723003/diff/10003/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/content_settings_handler.cc:427:
{"protectedContentHeader", IDS_PROTECTED_CONTENT_HEADER},
This appears to be unused in the code, as does the IDS, we should remove both.

[tommycli, 2017-02-07 22:11:26]

Description was changed from

==========
Settings: Make Enable DRM checkbox available on all platforms

This CL affects Old Options (not MD) and does two things:
 1. Updates strings to reflect that this checkbox toggles DRM entirely.
 2. Makes this checkbox available to all platforms.

It doesn't touch MD Settings for M57 merge-ability reasons.

BUG=686430
==========

to

==========
Settings: Make Enable DRM checkbox available on all platforms

This CL affects Old Options (not MD) and does two things:
 1. Updates strings to reflect that this checkbox toggles DRM entirely.
 2. Makes this checkbox available to all platforms.

It doesn't touch MD Settings for M57 merge-ability reasons.

BUG=686430
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-02-07 22:11:44]

thanks!

https://codereview.chromium.org/2679723003/diff/10003/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

https://codereview.chromium.org/2679723003/diff/10003/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/content_settings_handler.cc:427:
{"protectedContentHeader", IDS_PROTECTED_CONTENT_HEADER},
On 2017/02/07 21:43:52, stevenjb wrote:
> This appears to be unused in the code, as does the IDS, we should remove both.

Hey, it's used here:
https://cs.chromium.org/chromium/src/chrome/browser/resources/options/content...

I tested it. It doesn't work if i remove this line.

[stevenjb, 2017-02-07 22:15:05]

https://codereview.chromium.org/2679723003/diff/10003/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

https://codereview.chromium.org/2679723003/diff/10003/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/content_settings_handler.cc:427:
{"protectedContentHeader", IDS_PROTECTED_CONTENT_HEADER},
On 2017/02/07 22:11:44, tommycli wrote:
> On 2017/02/07 21:43:52, stevenjb wrote:
> > This appears to be unused in the code, as does the IDS, we should remove
both.
> 
> Hey, it's used here:
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/options/content...
> 
> I tested it. It doesn't work if i remove this line.

Oh, ugh. That's the problem with generated ids. And that's only used by Chrome
OS? Given that that code is general purpose, it might be safer just to make this
string non cros specific also?

[tommycli, 2017-02-07 22:19:37]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2017-02-07 22:19:50]

thanks!

https://codereview.chromium.org/2679723003/diff/10003/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

https://codereview.chromium.org/2679723003/diff/10003/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/content_settings_handler.cc:427:
{"protectedContentHeader", IDS_PROTECTED_CONTENT_HEADER},
On 2017/02/07 22:15:05, stevenjb wrote:
> On 2017/02/07 22:11:44, tommycli wrote:
> > On 2017/02/07 21:43:52, stevenjb wrote:
> > > This appears to be unused in the code, as does the IDS, we should remove
> both.
> > 
> > Hey, it's used here:
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/options/content...
> > 
> > I tested it. It doesn't work if i remove this line.
> 
> Oh, ugh. That's the problem with generated ids. And that's only used by Chrome
> OS? Given that that code is general purpose, it might be safer just to make
this
> string non cros specific also?
> 

Sure. I made the string crossplatform as well.

[stevenjb, 2017-02-07 22:21:02]

lgtm

[commit-bot: I haz the power, 2017-02-07 22:21:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-02-07 22:24:00]

On 2017/02/07 22:21:02, stevenjb wrote:
> lgtm

thanks steven

[tommycli, 2017-02-07 22:24:03]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-02-07 22:24:04]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-02-07 22:24:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-02-07 22:36:34]

The CQ bit was unchecked by tommycli@chromium.org