Chromium Code Reviews
DescriptionConvert IIRFilter tests to testharness.
These were converted using the script
for f in `grep -l Audit *.html`
do
# Replace js-test with testharness and add testharnessreport.js
sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
# Remove old js-test methods that no longer exist.
sed -i '/^[ ]*\(description(.*)\|finishJSTest()\);[ ]*$/d' $f
# Remove jsTestIsAsync stuff
sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f
# Remove expected results file.
base=`basename $f .html`
git rm $base-expected.txt
done
Some manual changes were needed to convert testPassed/testFailed to
Should().summarize().
Expected results removed since they're not needed.
BUG=688409
TEST=iirfilter-basic.html, iirfilter-getFrequencyResponse.html,
iirfilter.html
Review-Url: https://codereview.chromium.org/2676853002
Cr-Commit-Position: refs/heads/master@{#449492}
Committed: https://chromium.googlesource.com/chromium/src/+/9e94675bc4179ed1555208e39a862a97f0065d62
Patch Set 1 #Patch Set 2 : Minor cleanup #
Total comments: 1
Patch Set 3 : Reindent per review #Patch Set 4 : Add missing arg to Should() #
Messages
Total messages: 14 (8 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||