Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2676853002: Convert IIRFilter tests to testharness. (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert IIRFilter tests to testharness. These were converted using the script for f in `grep -l Audit *.html` do # Replace js-test with testharness and add testharnessreport.js sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\ \1\2testharnessreport.js\3 ;' $f # Remove old js-test methods that no longer exist. sed -i '/^[ ]*\(description(.*)\|finishJSTest()\);[ ]*$/d' $f # Remove jsTestIsAsync stuff sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f # Remove expected results file. base=`basename $f .html` git rm $base-expected.txt done Some manual changes were needed to convert testPassed/testFailed to Should().summarize(). Expected results removed since they're not needed. BUG=688409 TEST=iirfilter-basic.html, iirfilter-getFrequencyResponse.html, iirfilter.html Review-Url: https://codereview.chromium.org/2676853002 Cr-Commit-Position: refs/heads/master@{#449492} Committed: https://chromium.googlesource.com/chromium/src/+/9e94675bc4179ed1555208e39a862a97f0065d62

Patch Set 1 #

Patch Set 2 : Minor cleanup #

Total comments: 1

Patch Set 3 : Reindent per review #

Patch Set 4 : Add missing arg to Should() #

Messages

Total messages: 14 (8 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-08 16:10:46 UTC) #2
hongchan
lgtm https://codereview.chromium.org/2676853002/diff/20001/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-getFrequencyResponse.html File third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-getFrequencyResponse.html (right): https://codereview.chromium.org/2676853002/diff/20001/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-getFrequencyResponse.html#newcode79 third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-getFrequencyResponse.html:79: .summarize("matched expected response", "did not match expected response"); ...
3 years, 10 months ago (2017-02-09 21:57:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676853002/40001
3 years, 10 months ago (2017-02-09 22:13:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/385468)
3 years, 10 months ago (2017-02-09 23:18:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676853002/60001
3 years, 10 months ago (2017-02-09 23:42:39 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 00:41:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9e94675bc4179ed1555208e39a86...

Powered by Google App Engine
This is Rietveld 408576698