Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter.html

Issue 2676853002: Convert IIRFilter tests to testharness. (Closed)
Patch Set: Add missing arg to Should() Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-basic.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter.html b/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter.html
index c6c9c91fb6242902e45c08ae945ef2a83574fd3d..2053af5b67608c1a781d3d47011289cc6e9ad8f3 100644
--- a/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter.html
+++ b/third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter.html
@@ -2,7 +2,8 @@
<html>
<head>
<title>Test Basic IIRFilterNode Operation</title>
- <script src="../../resources/js-test.js"></script>
+ <script src="../../resources/testharness.js"></script>
+ <script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
<script src="../resources/audio-testing.js"></script>
<script src="../resources/biquad-filters.js"></script>
@@ -10,9 +11,6 @@
<body>
<script>
- description("Test Basic IIRFilterNode Operation");
- window.jsTestIsAsync = true;
-
var sampleRate = 48000;
var testDurationSec = 1;
var testFrames = testDurationSec * sampleRate;
@@ -88,10 +86,8 @@
// IIRFilterNode and the BiquadFilterNode.
success = Should("Output of IIR filter with unnormalized coefficients", iir2Data)
.beCloseToArray(iir1Data, 2.1958e-38) && success;
- if (success)
- testPassed("IIRFilter coefficients correctly normalized.\n");
- else
- testFailed("IIRFilter coefficients not correctly normalized.\n");
+ Should("IIRFilter coefficients normalized", success)
+ .summarize("correctly", "incorrectly");
}).then(done);
});
@@ -367,13 +363,10 @@
}).beLessThanOrEqualTo(errorThresholds[channel]);
}
- if (success) {
- testPassed("IIRFilter correctly processed " + result.numberOfChannels +
- "-channel input.");
- } else {
- testFailed("IIRFilter failed to correctly process " + result.numberOfChannels +
- "-channel input.");
- }
+ Should("IIRFIlter processed " + result.numberOfChannels +
+ "-channel input",
+ success)
+ .summarize("correctly", "incorrectly");
}).then(done);
});
@@ -566,13 +559,7 @@
}).then(done);
});
- audit.defineTask("finish", function (done) {
- finishJSTest();
- done();
- });
-
audit.runTasks();
- successfullyParsed = true;
</script>
</body>
</html>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/IIRFilter/iirfilter-basic.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698