ash: Clean up shelf GetAlignment() and IsHorizontalAlignment() calls

ash: Clean up shelf GetAlignment() and IsHorizontalAlignment() calls

This resolves some TODOs left over from shelf refactoring.

Eliminate various GetAlignment() utility functions and instead call into
WmShelf::GetAlignment() directory.

Prefer WmShelf::IsHorizontalAlignment() to the bare utility fuction.

Fix IWYU violations.

BUG=635963
TEST=ash_unittests
TBR=dmazzoni@chromium.org for IWYU in c/b/chromeos/accessibility

Review-Url: https://codereview.chromium.org/2676673005
Cr-Commit-Position: refs/heads/master@{#448035}
Committed: https://chromium.googlesource.com/chromium/src/+/9eb0f91135b98152c4dfa1b9779287ac2e5ac362

[James Cook, 2017-02-03 05:15:02]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 05:15:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-02-03 05:15:35]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2017-02-03 05:15:36]

msw, please take a look.

[commit-bot: I haz the power, 2017-02-03 05:45:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 05:45:22]

Dry run: This issue passed the CQ dry run.

[msw, 2017-02-03 08:48:05]

nice, lgtm

[James Cook, 2017-02-03 18:25:57]

Description was changed from

==========
ash: Clean up shelf GetAlignment() and IsHorizontalAlignment() calls

This resolves some TODOs left over from shelf refactoring.

Eliminate various GetAlignment() utility functions and instead call into
WmShelf::GetAlignment() directory.

Prefer WmShelf::IsHorizontalAlignment() to the bare utility fuction.

Fix IWYU violations.

BUG=635963
TEST=ash_unittests
==========

to

==========
ash: Clean up shelf GetAlignment() and IsHorizontalAlignment() calls

This resolves some TODOs left over from shelf refactoring.

Eliminate various GetAlignment() utility functions and instead call into
WmShelf::GetAlignment() directory.

Prefer WmShelf::IsHorizontalAlignment() to the bare utility fuction.

Fix IWYU violations.

BUG=635963
TEST=ash_unittests
TBR=dmazzoni@chromium.org for IWYU in c/b/chromeos/accessibility
==========

[James Cook, 2017-02-03 18:26:21]

TBR dmazzoni for adding an include in c/b/chromeos/accessibility to fix IWYU

[James Cook, 2017-02-03 18:26:26]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-02-03 18:27:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 19:13:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486146386583270, "parent_rev":
"e8bd03d5f99b0af859ad62ac6c7b52f58a10f3e9", "commit_rev":
"9eb0f91135b98152c4dfa1b9779287ac2e5ac362"}

[commit-bot: I haz the power, 2017-02-03 19:14:16]

Description was changed from

==========
ash: Clean up shelf GetAlignment() and IsHorizontalAlignment() calls

This resolves some TODOs left over from shelf refactoring.

Eliminate various GetAlignment() utility functions and instead call into
WmShelf::GetAlignment() directory.

Prefer WmShelf::IsHorizontalAlignment() to the bare utility fuction.

Fix IWYU violations.

BUG=635963
TEST=ash_unittests
TBR=dmazzoni@chromium.org for IWYU in c/b/chromeos/accessibility
==========

to

==========
ash: Clean up shelf GetAlignment() and IsHorizontalAlignment() calls

This resolves some TODOs left over from shelf refactoring.

Eliminate various GetAlignment() utility functions and instead call into
WmShelf::GetAlignment() directory.

Prefer WmShelf::IsHorizontalAlignment() to the bare utility fuction.

Fix IWYU violations.

BUG=635963
TEST=ash_unittests
TBR=dmazzoni@chromium.org for IWYU in c/b/chromeos/accessibility

Review-Url: https://codereview.chromium.org/2676673005
Cr-Commit-Position: refs/heads/master@{#448035}
Committed:
https://chromium.googlesource.com/chromium/src/+/9eb0f91135b98152c4dfa1b97792...
==========

[commit-bot: I haz the power, 2017-02-03 19:14:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9eb0f91135b98152c4dfa1b97792...