Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: third_party/WebKit/Source/bindings/IDLExtendedAttributes.md

Issue 2676663006: Remove SetWrapperReferenceTo and SetWrapperReferenceFrom (Closed)
Patch Set: Rebase on master Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
diff --git a/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md b/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
index d62a4af1ed9e86231fd871b79c8cfe6542a53b11..d0d4dc4a682a990a8a41e72eab0fcc19e0ebc59f 100644
--- a/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
+++ b/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
@@ -906,8 +906,7 @@ if the wrapper is unreachable on the JS side (i.e., V8's GC assumes that the wra
reachable in the DOM side). Use `[DependentLifetime]` to relax the assumption.
For example, if the DOM object has `[ActiveScriptWrappable]` and implements hasPendingActivity(), it must be annotated with
`[DependentLifetime]`. Otherwise, the wrapper will be collected regardless of the returned value
-of the hasPendingActivity(). DOM objects that are pointed to by `[SetWrapperReferenceFrom]` and
-`[SetWrapperReferenceTo]` must be annotated with `[DependentLifetime]`.
+of the hasPendingActivity().
### [DeprecateAs] _(m, a, c)_
@@ -1263,34 +1262,6 @@ Summary: Caches the resulting object and always returns the same object.
When specified, caches the resulting object and returns it in later calls so that the attribute always returns the same object. Must be accompanied with `[SameObject]`.
-### [SetWrapperReferenceFrom=xxx] _(i)_
-
-### [SetWrapperReferenceTo=xxx] _(i)_
-
-Summary: This generates code that allows you to set up implicit references between wrappers which can be used to keep wrappers alive during GC.
-
-Usage: `[SetWrapperReferenceFrom]` and `[SetWrapperReferenceTo]` can be specified on an interface. Use `[Custom=VisitDOMWrapper]` if want to write a custom function.
-
-```webidl
-[
- SetWrapperReferenceFrom=element
-] interface XXX { ... };
-```
-
-The code generates a function called `XXX::visitDOMWrapper` which is called by `V8GCController` before GC. The function adds implicit references from the specified object to this object's wrapper to keep it alive.
-
-The `[SetWrapperReferenceFrom]` extended attribute takes a value, which is the function to call to get the object that determines whether the object is reachable or not. The currently valid values are: `document`, `element`, `owner`, `ownerNode`
-
-```webidl
-[
- SetWrapperReferenceTo=targetMethod
-] interface YYY { ... };
-```
-
-The code generates a function called `YYY::visitDOMWrapper` which is called by `V8GCController` before GC. The function adds implicit references from this object's wrapper to a target object's wrapper to keeps it alive.
-
-The `[SetWrapperReferenceTo]` extended attribute takes a value, which is the method name to call to get the target object. For example, with the above declaration a call will be made to `YYY::targetMethod()` to get the target of the reference.
-
## Rare Blink-specific IDL Extended Attributes
These extended attributes are rarely used, generally only in one or two places. These are often replacements for `[Custom]` bindings, and may be candidates for deprecation and removal.
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698