Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2676593003: [Merge to 2998 for test build] [Mac] Version the //chrome:chrome_framework bundle. (Closed)

Created:
3 years, 10 months ago by Robert Sesek
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2998
Project:
chromium
Visibility:
Public.

Description

[Merge to 2998 for test build] [Mac] Version the //chrome:chrome_framework bundle. BUG=604809, 662466 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2484283003 Cr-Commit-Position: refs/heads/master@{#447763} (cherry picked from commit 5a1ebea8a247366ac822858e141983037a1f0059) Review-Url: https://codereview.chromium.org/2676593003 . Cr-Commit-Position: refs/branch-heads/2998@{#5} Cr-Branched-From: 2a9afa9fbfc5d76d668f3aeb70894f83d4686886-refs/heads/master@{#447146} Committed: https://chromium.googlesource.com/chromium/src/+/35483db6126d73c64f467503ece03c6a119d0a68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Robert Sesek
Committed patchset #1 (id:1) manually as 35483db6126d73c64f467503ece03c6a119d0a68.
3 years, 10 months ago (2017-02-02 15:31:16 UTC) #2
Dirk Pranke
3 years, 10 months ago (2017-02-02 22:23:46 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698