Chromium Code Reviews

Issue 2676543002: [stubs] Rip out obsolete CallICState. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Rip out obsolete CallICState. The CallIC is already not a traditional IC in the V8 sense, so it doesn't make sense to integrate with the traditional IC machinery. The plan is to migrate it away completely from the IC world and use the code that is already available in the interpreter instead. R=yangguo@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2676543002 Cr-Commit-Position: refs/heads/master@{#42879} Committed: https://chromium.googlesource.com/v8/v8/+/2a5046c458a06d9fe6114e342347debcb9513e29

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+34 lines, -51 lines)
M src/code-factory.cc View 2 chunks +2 lines, -2 lines 0 comments
M src/code-stubs.h View 4 chunks +27 lines, -11 lines 0 comments
M src/code-stubs.cc View 1 chunk +5 lines, -1 line 0 comments
M src/ic/ic-state.h View 1 chunk +0 lines, -32 lines 0 comments
M src/ic/ic-state.cc View 1 chunk +0 lines, -5 lines 0 comments

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-02 07:06:06 UTC) #1
Yang
On 2017/02/02 07:06:06, Benedikt Meurer wrote: lgtm.
3 years, 10 months ago (2017-02-02 07:08:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676543002/1
3 years, 10 months ago (2017-02-02 07:42:23 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 07:44:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2a5046c458a06d9fe6114e342347debcb95...

Powered by Google App Engine