Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2669123002: [stubs] Port CallICTrampolineStub to CodeStubAssembler. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Port CallICTrampolineStub to CodeStubAssembler. First step to unify CallIC in Ignition, TurboFan/Crankshaft and fullcodegen. R=yangguo@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2669123002 Cr-Commit-Position: refs/heads/master@{#42877} Committed: https://chromium.googlesource.com/v8/v8/+/9432eb5c6aab2b8e74c01a8a2f79e690eb94b3e2

Patch Set 1 #

Patch Set 2 : Fix the CSA verifier issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -74 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (11 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-02 06:31:33 UTC) #1
Yang
On 2017/02/02 06:31:33, Benedikt Meurer wrote: lgtm.
3 years, 10 months ago (2017-02-02 06:34:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669123002/20001
3 years, 10 months ago (2017-02-02 06:58:39 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 07:25:20 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9432eb5c6aab2b8e74c01a8a2f79e690eb9...

Powered by Google App Engine
This is Rietveld 408576698