third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h - Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h

Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted. (Closed)

Patch Set: address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h

index b3fc83679e9c274524b446173f6a848854313796..e0c33a88084ab9f8a455a5336b057db0c78abc01 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h

@@ -25,7 +25,7 @@ class CORE_EXPORT NGLayoutAlgorithm {

// constraints given by the NGConstraintSpace. Returns a fragment with the

// resulting layout information.

// TODO(layout-dev): attempt to make this function const.

- virtual NGPhysicalFragment* Layout() = 0;

+ virtual RefPtr<NGPhysicalFragment> Layout() = 0;

// Computes the min-content and max-content intrinsic sizes for the given box.

// The result will not take any min-width, max-width or width properties into