Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc

Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted. (Closed)
Patch Set: address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
index 5bb6c7802d3d406a264675e2be19422d9205f4e2..e744d94789457a78519085eb8d7337ea5e61a45d 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
@@ -63,9 +63,8 @@ class NGInlineNodeTest : public ::testing::Test {
style_->font().update(nullptr);
}
- void CreateLine(
- NGInlineNode* node,
- HeapVector<Member<const NGPhysicalTextFragment>>* fragments_out) {
+ void CreateLine(NGInlineNode* node,
+ Vector<RefPtr<const NGPhysicalTextFragment>>* fragments_out) {
NGConstraintSpace* constraint_space =
NGConstraintSpaceBuilder(kHorizontalTopBottom).ToConstraintSpace();
NGLineBuilder line_builder(node, constraint_space);
@@ -76,9 +75,9 @@ class NGInlineNodeTest : public ::testing::Test {
NGFragmentBuilder fragment_builder(NGPhysicalFragment::kFragmentBox,
/* layout_object */ nullptr);
line_builder.CreateFragments(&fragment_builder);
- NGPhysicalBoxFragment* fragment = fragment_builder.ToBoxFragment();
- for (const NGPhysicalFragment* child : fragment->Children()) {
- fragments_out->push_back(toNGPhysicalTextFragment(child));
+ RefPtr<NGPhysicalBoxFragment> fragment = fragment_builder.ToBoxFragment();
+ for (const auto& child : fragment->Children()) {
+ fragments_out->push_back(toNGPhysicalTextFragment(child.get()));
}
}
@@ -187,7 +186,7 @@ TEST_F(NGInlineNodeTest, SegmentBidiIsolate) {
TEST_F(NGInlineNodeTest, CreateLineBidiIsolate) {
NGInlineNodeForTest* node = CreateBidiIsolateNode(style_.get());
- HeapVector<Member<const NGPhysicalTextFragment>> fragments;
+ Vector<RefPtr<const NGPhysicalTextFragment>> fragments;
CreateLine(node, &fragments);
ASSERT_EQ(5u, fragments.size());
TEST_TEXT_FRAGMENT(fragments[0], node, 0u, 1u, TextDirection::kLtr);

Powered by Google App Engine
This is Rietveld 408576698