third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h - Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h

Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted. (Closed)

Patch Set: address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h b/third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h

index f18a7864cdabadea0396bdbd577d7a75a66dee8d..ed282c8176d80d721885162ebee8947cc7259833 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h

@@ -25,7 +25,7 @@ class CORE_EXPORT NGLayoutInputNode

virtual ~NGLayoutInputNode(){};

// Performs layout on this input node, will return a new fragment.

- virtual NGPhysicalFragment* Layout(NGConstraintSpace*) = 0;

+ virtual RefPtr<NGPhysicalFragment> Layout(NGConstraintSpace*) = 0;

// Returns the next sibling.

virtual NGLayoutInputNode* NextSibling() = 0;